Fix build and address review feedback
This commit is contained in:
		@@ -65,14 +65,14 @@ bool Filter::ParseFilterRule(const std::string::const_iterator begin,
 | 
			
		||||
                             const std::string::const_iterator end) {
 | 
			
		||||
    auto level_separator = std::find(begin, end, ':');
 | 
			
		||||
    if (level_separator == end) {
 | 
			
		||||
        LOG_ERROR(Log, "Invalid log filter. Must specify a log level after `:`: %s",
 | 
			
		||||
                  std::string(begin, end).c_str());
 | 
			
		||||
        LOG_ERROR(Log, "Invalid log filter. Must specify a log level after `:`: {}",
 | 
			
		||||
                  std::string(begin, end));
 | 
			
		||||
        return false;
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    const Level level = GetLevelByName(level_separator + 1, end);
 | 
			
		||||
    if (level == Level::Count) {
 | 
			
		||||
        LOG_ERROR(Log, "Unknown log level in filter: %s", std::string(begin, end).c_str());
 | 
			
		||||
        LOG_ERROR(Log, "Unknown log level in filter: {}", std::string(begin, end));
 | 
			
		||||
        return false;
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
@@ -83,7 +83,7 @@ bool Filter::ParseFilterRule(const std::string::const_iterator begin,
 | 
			
		||||
 | 
			
		||||
    const Class log_class = GetClassByName(begin, level_separator);
 | 
			
		||||
    if (log_class == Class::Count) {
 | 
			
		||||
        LOG_ERROR(Log, "Unknown log class in filter: %s", std::string(begin, end).c_str());
 | 
			
		||||
        LOG_ERROR(Log, "Unknown log class in filter: {}", std::string(begin, end));
 | 
			
		||||
        return false;
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
 
 | 
			
		||||
@@ -7,6 +7,7 @@
 | 
			
		||||
#include <string>
 | 
			
		||||
#include <thread>
 | 
			
		||||
 | 
			
		||||
#include "common/common_paths.h"
 | 
			
		||||
#include "common/logging/backend.h"
 | 
			
		||||
#include "common/logging/filter.h"
 | 
			
		||||
#include "common/logging/log.h"
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user