emu_window: Pass OnMinimalClientAreaChangeRequest argument by copy
There's no performance improvement in passing an unsigned pair by reference.
This commit is contained in:
		@@ -169,8 +169,7 @@ private:
 | 
			
		||||
     * For the request to be honored, EmuWindow implementations will usually reimplement this
 | 
			
		||||
     * function.
 | 
			
		||||
     */
 | 
			
		||||
    virtual void OnMinimalClientAreaChangeRequest(
 | 
			
		||||
        const std::pair<unsigned, unsigned>& minimal_size) {
 | 
			
		||||
    virtual void OnMinimalClientAreaChangeRequest(std::pair<unsigned, unsigned>) {
 | 
			
		||||
        // By default, ignore this request and do nothing.
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
 
 | 
			
		||||
@@ -440,8 +440,7 @@ void GRenderWindow::CaptureScreenshot(u16 res_scale, const QString& screenshot_p
 | 
			
		||||
                               layout);
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
void GRenderWindow::OnMinimalClientAreaChangeRequest(
 | 
			
		||||
    const std::pair<unsigned, unsigned>& minimal_size) {
 | 
			
		||||
void GRenderWindow::OnMinimalClientAreaChangeRequest(std::pair<unsigned, unsigned> minimal_size) {
 | 
			
		||||
    setMinimumSize(minimal_size.first, minimal_size.second);
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
 
 | 
			
		||||
@@ -162,8 +162,7 @@ private:
 | 
			
		||||
    void TouchUpdateEvent(const QTouchEvent* event);
 | 
			
		||||
    void TouchEndEvent();
 | 
			
		||||
 | 
			
		||||
    void OnMinimalClientAreaChangeRequest(
 | 
			
		||||
        const std::pair<unsigned, unsigned>& minimal_size) override;
 | 
			
		||||
    void OnMinimalClientAreaChangeRequest(std::pair<unsigned, unsigned> minimal_size) override;
 | 
			
		||||
 | 
			
		||||
    QWidget* container = nullptr;
 | 
			
		||||
    GGLWidgetInternal* child = nullptr;
 | 
			
		||||
 
 | 
			
		||||
@@ -172,7 +172,6 @@ void EmuWindow_SDL2::PollEvents() {
 | 
			
		||||
    }
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
void EmuWindow_SDL2::OnMinimalClientAreaChangeRequest(
 | 
			
		||||
    const std::pair<unsigned, unsigned>& minimal_size) {
 | 
			
		||||
void EmuWindow_SDL2::OnMinimalClientAreaChangeRequest(std::pair<unsigned, unsigned> minimal_size) {
 | 
			
		||||
    SDL_SetWindowMinimumSize(render_window, minimal_size.first, minimal_size.second);
 | 
			
		||||
}
 | 
			
		||||
 
 | 
			
		||||
@@ -50,8 +50,7 @@ protected:
 | 
			
		||||
    void Fullscreen();
 | 
			
		||||
 | 
			
		||||
    /// Called when a configuration change affects the minimal size of the window
 | 
			
		||||
    void OnMinimalClientAreaChangeRequest(
 | 
			
		||||
        const std::pair<unsigned, unsigned>& minimal_size) override;
 | 
			
		||||
    void OnMinimalClientAreaChangeRequest(std::pair<unsigned, unsigned> minimal_size) override;
 | 
			
		||||
 | 
			
		||||
    /// Is the window still open?
 | 
			
		||||
    bool is_open = true;
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user