OpenPunk/citra
1
0
Fork 0
mirror of https://github.com/citra-emu/citra.git synced 2024-11-23 04:50:10 +00:00
Code Issues Projects Releases Wiki Activity
8,736 Commits 1 Branch 0 Tags 135 MiB
2632b421c2
Commit Graph

8736 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Mat M
e9819b61a6
service: Mark variables as [[maybe_unused]] where applicable (#5318) 
Quite a few service functions are stubbed but still pop all their
arguments, which can lead to unused variable warnings.

We can mark the unused arguments with [[maybe_unused]] to silence these
warnings until a full implementation of these functions are made.
 2020-05-04 12:22:33 +02:00
Mat M
6e48149ee1
fs/archive: Make use of std::make_shared where applicable (#5319) 
Allows implementations to allocate the object and the shared_ptr control
block in one allocation instead of needing to do two separate
allocations.

Also looks much nicer to the reader.
 2020-05-04 12:22:13 +02:00
Mat M
79536ddb11
service/cfg: Convert file-scope std::vector to std::array (#5320) 
Same behavior, but without a static runtime constructor that needs to
run at program start.
 2020-05-04 12:21:56 +02:00
Mat M
30414eeb4b
service/cfg: Make GenerateConsoleUniqueId() return a pair (#5321) 
Same behavior, but allows the use of structured bindings.
 2020-05-04 12:21:43 +02:00
Valentin Vanelslande
41abdb505c
common/logging/log: Add LLE in Audio_DSP comment (#5327) 
@wwylele forgot to add it in https://github.com/citra-emu/citra/pull/4490.
 2020-05-04 12:20:56 +02:00
Ben
2874401703
cfg-savegame: add DebugMode block (#5330) 2020-05-04 12:19:44 +02:00
B3n30
ed48f8accf clang-format fix 2020-05-04 12:14:40 +02:00
zhaobot
7f1a87574b
Update translations (2020-05-01) (#5289) 
* Update translations (2020-05-01)

* Update dist/languages/zh_CN.ts

Co-authored-by: rcyggdra <rcyggdra@gmail.com>

Co-authored-by: The Citra Community <noreply-fake@community.citra-emu.org>
Co-authored-by: Pengfei Zhu <zhupf321@gmail.com>
Co-authored-by: rcyggdra <rcyggdra@gmail.com>
 2020-05-04 11:31:49 +02:00
Pengfei Zhu
60669a7dd8
swkbd: Fix a bug where clicking Cancel hangs the game (#5294) 
* swkbd: Fix a bug where clicking Cancel hangs the game

The text is validated in `Finalize`. If the validation fails, an error is returned and the applet is not actually finalized. This can result in hangs.

This is usually not a problem as the frontend is expected to validate the text passed to `Finalize`. However, when the user clicked on `Cancel`, the text is ignored and the frontend won't do any validation. Therefore, we should skip the validation here as well.

Also fixed a potential data race. All these functions should now be called on the same thread

* Address review comments

Renamed the fields
Remove close button
 2020-05-04 11:31:17 +02:00
Pengfei Zhu
41bff0e3b7
Merge pull request #5316 from lioncash/init 
core: Resolve -Wreorder warnings
 2020-05-02 15:42:31 +08:00
Pengfei Zhu
eb996f046d
Merge pull request #5315 from lioncash/undef 
soc_u: Prevent undefined behavior with CTRPollFD
 2020-05-02 15:41:59 +08:00
Lioncash
563a540dfd core: Resolve -Wreorder warnings 
Ensures the initialization order matches the actual order that the class
member variables will be initialized in.
 2020-05-01 23:32:46 -04:00
Lioncash
a32ad7f1f2 soc_u: Prevent undefined behavior with CTRPollFD 
This class is memcpy-ed and memcpy has the requirement that data passed
to it must be trivially copyable, otherwise the behavior is undefined.

This is trivial to resolve as BitField was made trivially copyable a
while ago, so this explicit copy assignment operator isn't necessary.
 2020-05-01 22:30:10 -04:00
Pengfei Zhu
2476532f21
Merge pull request #5302 from lioncash/teak 
CMakeLists: Specify EXCLUDE_FROM_ALL for teakra
 2020-05-02 10:21:18 +08:00
Pengfei Zhu
e212dc3a1f
Merge pull request #5297 from lioncash/missing 
gl_rasterizer: Amend missing return value in branch in SetupGeometryShader()
 2020-05-02 08:07:49 +08:00
Pengfei Zhu
70a43be714
Merge pull request #5306 from lioncash/view2 
file-sys: Make use of std::string_view where applicable
 2020-05-02 08:07:10 +08:00
Pengfei Zhu
8e7abecf7e
Merge pull request #5307 from lioncash/guard 
file_sys/seed_db: Add missing include guard
 2020-05-02 08:04:58 +08:00
Pengfei Zhu
5a008a74fa
Merge pull request #5304 from lioncash/layered 
layered_fs: Mark functions as static where applicable
 2020-05-02 08:02:35 +08:00
Pengfei Zhu
6907568034
Merge pull request #5309 from lioncash/dtor 
applets: Make destructors virtual where applicable
 2020-05-02 08:02:14 +08:00
Pengfei Zhu
59984df603
Merge pull request #5308 from lioncash/rsa 
core/hw/rsa: Minor cleanup
 2020-05-02 08:01:58 +08:00
David Marcec
5832857bc0 externals: Update cubeb to 616d773 
Support for 6 audio channels

Co-Authored-By: David <ognik5377@users.noreply.github.com>
 2020-05-01 22:15:50 +02:00
Pengfei Zhu
4d7487bd34
Merge pull request #5298 from lioncash/unused 
gl_rasterizer: Silence various compilation warnings
 2020-05-01 23:34:36 +08:00
Pengfei Zhu
037c857bd6
Merge pull request #5303 from lioncash/namespace 
service/ir: Remove erroneous forward declaration
 2020-05-01 23:04:01 +08:00
Pengfei Zhu
017f0c469e
Merge pull request #5301 from lioncash/chunk 
common: Remove chunk_file.h
 2020-05-01 23:02:47 +08:00
Pengfei Zhu
6a0636d631
Merge pull request #5296 from lioncash/flatten 
gl_rasterizer_cache: Flatten LoadCustomTexture()
 2020-05-01 23:01:47 +08:00
Pengfei Zhu
2eacb11c53
Merge pull request #5292 from lioncash/alloc 
gl_shader_manager: Eliminate variable shadowing
 2020-05-01 22:57:55 +08:00
Pengfei Zhu
1bb9a71a01
Merge pull request #5291 from lioncash/trunc 
renderer_opengl: Resolve compiler truncation warnings
 2020-05-01 22:56:46 +08:00
Lioncash
89eeb64854 applets/swkbd: Make destructor virtual 
Prevents undefined behavior when destroying a derived class through a
base class pointer.
 2020-05-01 10:44:31 -04:00
Lioncash
aeb6a037ed applets/mii_selector: Make destructor virtual 
Prevents undefined behavior when destroying derived classes through a
base class pointer.
 2020-05-01 10:42:57 -04:00
Lioncash
3ab0701192 core/hw/rsa: Make GetSignature() a const member function 
This doesn't directly modify instance state, so it can be made const.
 2020-05-01 10:17:43 -04:00
Ben
fd1b254635
Merge pull request #5290 from lioncash/shader 
gl_shader_gen: Minor interface cleanup
 2020-05-01 16:16:25 +02:00
Lioncash
c55e81b946 core/hw/rsa: Make operator bool explicit 
Prevents error-prone implicit conversions to bool from occurring.
 2020-05-01 10:14:50 -04:00
Lioncash
75bac1e514 core/hw/rsa: Take std::vector instances by value 
Allows us to std::move them and allow calling code to eliminate copies
from occurring entirely.
 2020-05-01 10:14:07 -04:00
Lioncash
98385b75d6 file_sys/seed_db: Add missing include guard 
Prevents any potential inclusion errors from occurring.
 2020-05-01 09:59:58 -04:00
Lioncash
10a32c94b6 title_metadata: Take std::vector by const reference in Load() 
This isn't modified in the implementation, so this can be a const
reference to eliminate an unnecessary heap reallocation.
 2020-05-01 09:53:44 -04:00
Lioncash
147073a5a0 file-sys: Make use of std::string_view where applicable 
Same behavior, but makes the interface more flexible and allows
non-std::string instances to be used with it.
 2020-05-01 09:49:36 -04:00
Lioncash
37a6ea72e5 layered_fs: Mark functions as static where applicable 
Makes them internally linked and prevents potential
-Wmissing-declaration warnings.
 2020-05-01 09:35:59 -04:00
Lioncash
9cff314abb service/ir: Remove erroneous forward declaration 
This can be removed as it's not used. Even if it were however, it would
be an incorrect forward declaration, as ServiceManager exists within the
Service::SM namespace, not the top-level SM namespace.
 2020-05-01 08:54:27 -04:00
Lioncash
7d5cad4093 CMakeLists: Specify EXCLUDE_FROM_ALL for teakra 
Ensures that unused targets introduced in the add_subdirectory call
don't show up in IDE builds if they aren't used (which is the case for
teakra_c).
 2020-05-01 08:31:58 -04:00
Lioncash
246cea229c common: Remove chunk_file.h 
This is part of Dolphin's serialization code, which isn't used and
probably never will be, considering that savestates are implemented with
boost.
 2020-05-01 08:23:59 -04:00
Lioncash
763778e6c0 gl_rasterizer: Make const on references consistent 
Applies const to auto& instances that would actually resolve to a const
reference for readability and explicitness.
 2020-05-01 06:19:20 -04:00
Lioncash
437453d32b gl_rasterizer: Amend missing return value in branch in SetupGeometryShader() 
Previously undefined behavior was being invoked in the case that
geometry shaders weren't supported.
 2020-05-01 06:10:32 -04:00
Lioncash
81768bf0c2 gl_rasterizer: Resolve truncation warnings 2020-05-01 06:08:20 -04:00
Lioncash
df97021f55 gl_rasterizer: Make use of std::string_view in IsVendorAmd() 
Same behavior, no heap allocation.

strings returned from glGetString() are guaranteed to be static strings,
so this is safe to do. They're also guaranteed to be null-terminated.
 2020-05-01 05:57:25 -04:00
Lioncash
de140a5870 gl_rasterizer: Default destructor in the cpp file 2020-05-01 05:53:40 -04:00
Lioncash
ea08178dde gl_rasterizer: Remove unused emu_window variable in RasterizerOpenGL 
Silences an unused private variable warning.
 2020-05-01 05:52:48 -04:00
Lioncash
59a614a70f gl_rasterizer_cache: Remove unnecessary reference parameter in LoadCustomTexture() 
This is only ever used in a self-referential manner, so we can make use
of the texture info member directly.
 2020-05-01 05:42:35 -04:00
Lioncash
e342f36e02 gl_rasterizer_cache: Flatten LoadCustomTexture() 
Makes the control flow much nicer to follow, as we don't store to a
local before returning anymore.
 2020-05-01 05:33:47 -04:00
Mat M
85d37c9994
gl_shader_disk: Make use of std::nullopt where applicable (#5293) 
Some implementations can use the std::nullopt_t constructor of
std::optional to avoid needing to completely zero out the internal
buffer of the optional and instead only set the validity byte within it.

e.g. Consider the following function:

std::optional<std::vector<ShaderDiskCacheRaw>> fn() {
    return {};
}

With libc++ this will result in the following code generation on x86-64:

Fn():
  mov     rax, rdi
  vxorps  xmm0, xmm0, xmm0
  vmovups ymmword ptr [rdi], ymm0
  vzeroupper
  ret

With libstdc++, we also get the similar equivalent:

Fn():
  vpxor   xmm0, xmm0, xmm0
  mov     rax, rdi
  vmovdqu XMMWORD PTR [rdi], xmm0
  vmovdqu XMMWORD PTR [rdi+16], xmm0
  ret

If we change this function to return std::nullopt instead, then this
simplifies both the code gen from libc++ and libstdc++ down to:

Fn():
  mov     BYTE PTR [rdi+24], 0
  mov     rax, rdi
  ret

Given how little of a change is necessary to result in better code
generation, this is essentially a "free" very minor optimization.
 2020-04-30 22:42:32 -05:00
Lioncash
f20120e5a7 gl_shader_gen: Mark hash implementations as noexcept 
These shouldn't throw at all, so we can mark the interface as such.
 2020-04-30 22:57:36 -04:00