Avoid windows build-dir lock by using per-version build folders

.github/workflows/check-builds.yaml

@@ -84,11 +84,8 @@ jobs:
           Invoke-Expression "vcpkg integrate install"
 
           foreach ($version in $versions) {
-              if (Test-Path -LiteralPath "build") {
-                  Remove-Item "build" -Recurse
-                  Write-Output "Deleted existing build folder"
-              }
-              Invoke-Expression "cmake -B build -DPROTOCOL_VERSION=$version -DCMAKE_TOOLCHAIN_FILE=C:/vcpkg/scripts/buildsystems/vcpkg.cmake"
+              $buildDir = "build-$version"
+              Invoke-Expression "cmake -B $buildDir -DPROTOCOL_VERSION=$version -DCMAKE_TOOLCHAIN_FILE=C:/vcpkg/scripts/buildsystems/vcpkg.cmake"
               if ($LASTEXITCODE -ne "0") {
                   Write-Error "cmake generation failed for version $version" -ErrorAction Stop
               }
@@ -96,7 +93,7 @@ jobs:
 
               foreach ($configuration in $configurations) {
                   Write-Output "Building version $version $configuration"
-                  Invoke-Expression "msbuild build\OpenFusion.sln /maxcpucount:8 /p:BuildInParallel=true /p:CL_MPCount=8 /p:UseMultiToolTask=true /p:Configuration=$configuration"
+                  Invoke-Expression "msbuild $buildDir\OpenFusion.sln /maxcpucount:8 /nodeReuse:false /p:BuildInParallel=true /p:CL_MPCount=8 /p:UseMultiToolTask=true /p:Configuration=$configuration"
                   if ($LASTEXITCODE -ne "0") {
                       Write-Error "msbuild build failed for version $version" -ErrorAction Stop
                   }

src/Missions.cpp

@@ -595,10 +595,17 @@ void Missions::mobKilled(CNSocket *sock, int mobid, std::map<int, int>& rolls) {
             }
 
             // drop quest item
-            if (task["m_iCSUItemNumNeeded"][j] != 0 && !isQuestItemFull(sock, task["m_iCSUItemID"][j], task["m_iCSUItemNumNeeded"][j]) ) {
+            if (task["m_iCSUItemNumNeeded"][j] != 0) {
+                if (!isQuestItemFull(sock, task["m_iCSUItemID"][j], task["m_iCSUItemNumNeeded"][j])) {
                     bool drop = rolls[plr->tasks[i]] % 100 < task["m_iSTItemDropRate"][j];
                     if (drop) {
                         dropQuestItem(sock, plr->tasks[i], 1, task["m_iCSUItemID"][j], mobid);
+                    }
+                    else {
+                        // fail to drop (itemID == 0)
+                        dropQuestItem(sock, plr->tasks[i], 1, 0, mobid);
+                    }
+                }
                 
                 /*
                 * Workaround: The client has a bug where it only sends a TASK_END request
@@ -616,10 +623,6 @@ void Missions::mobKilled(CNSocket *sock, int mobid, std::map<int, int>& rolls) {
 
                     sock->sendPacket(end, P_FE2CL_REP_PC_TASK_END_SUCC);
                 }
-                } else {
-                    // fail to drop (itemID == 0)
-                    dropQuestItem(sock, plr->tasks[i], 1, 0, mobid);
-                }
             }
         }
     }