OpenPunk/OpenFusion
1
0
Fork 0
mirror of https://github.com/OpenFusionProject/OpenFusion.git synced 2025-09-29 19:20:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

[refactor] Validate all inbound packets before handling them

Browse Source
This commit is contained in:
dongresource
2021-03-19 02:32:07 +01:00
parent 7c7d9f1be8
commit ef7d0148c6
8 changed files with 321 additions and 231 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/servers/CNLoginServer.cpp
View File

@@ -17,7 +17,7 @@ CNLoginServer::CNLoginServer(uint16_t p) {
}
void CNLoginServer::handlePacket(CNSocket* sock, CNPacketData* data) {
printPacket(data, CL2LS);
printPacket(data);
switch (data->type) {
case P_CL2LS_REQ_LOGIN: {
@@ -62,7 +62,7 @@ void CNLoginServer::handlePacket(CNSocket* sock, CNPacketData* data) {
}
default:
if (settings::VERBOSITY)
std::cerr << "OpenFusion: LOGIN UNIMPLM ERR. PacketType: " << Packets::p2str(CL2LS, data->type) << " (" << data->type << ")" << std::endl;
std::cerr << "OpenFusion: LOGIN UNIMPLM ERR. PacketType: " << Packets::p2str(data->type) << " (" << data->type << ")" << std::endl;
break;
/*
* Unimplemented CL2LS packets:

4
src/servers/CNShardServer.cpp
View File

@@ -27,12 +27,12 @@ CNShardServer::CNShardServer(uint16_t p) {
}
void CNShardServer::handlePacket(CNSocket* sock, CNPacketData* data) {
printPacket(data, CL2FE);
printPacket(data);
if (ShardPackets.find(data->type) != ShardPackets.end())
ShardPackets[data->type](sock, data);
else if (settings::VERBOSITY > 0)
std::cerr << "OpenFusion: SHARD UNIMPLM ERR. PacketType: " << Packets::p2str(CL2FE, data->type) << " (" << data->type << ")" << std::endl;
std::cerr << "OpenFusion: SHARD UNIMPLM ERR. PacketType: " << Packets::p2str(data->type) << " (" << data->type << ")" << std::endl;
if (PlayerManager::players.find(sock) != PlayerManager::players.end())
PlayerManager::players[sock]->lastHeartbeat = getTime();