Fix timed out buffs not calling onExpire

2022-07-19 09:14:38 -07:00 · 2022-07-19 09:14:38 -07:00 · da38bbec29
parent a07f36e379
commit da38bbec29
1 changed files with 5 additions and 1 deletions
--- a/src/Buffs.cpp
+++ b/src/Buffs.cpp
@ -12,8 +12,12 @@ void Buff::tick() {

        if(stack.durationTicks > 0) stack.durationTicks--;
        if(stack.durationTicks == 0) {
+            // erase() destroys the callbacks
+            // with the stack struct, so we need
+            // to copy it first.
+            BuffStack deadStack = stack;
            it = stacks.erase(it);
-            if(stack.onExpire) stack.onExpire(self, &stack);
+            if(deadStack.onExpire) deadStack.onExpire(self, &deadStack);
        } else it++;
    }
 }