Fix delayed loading of nano skill icons

We actually don't need to wait for post-load to do the second nano book send.
That adds unnecessary delay. Moving it to right after `P_FE2CL_REP_PC_ENTER_SUCC`
does the trick and gives the client plenty of time to fetch the icons before
loading in-game.
This commit is contained in:
gsemaj 2024-06-25 15:21:32 -07:00
parent b0e2391f24
commit 1781ac6b03
No known key found for this signature in database
GPG Key ID: 24B96BAA40497929

View File

@ -293,12 +293,14 @@ static void enterPlayer(CNSocket* sock, CNPacketData* data) {
sock->setActiveKey(SOCKETKEY_FE); // send all packets using the FE key from now on
// Academy builds receive nanos in a separate packet. These need to be sent
// before P_FE2CL_REP_PC_ENTER_SUCC as well as after initial load
// before P_FE2CL_REP_PC_ENTER_SUCC as well as after
// due to a race condition in the client :(
sendNanoBookSubset(sock, plr);
sock->sendPacket(response, P_FE2CL_REP_PC_ENTER_SUCC);
sendNanoBookSubset(sock, plr);
// transfer ownership of Player object into the shard (still valid in this function though)
addPlayer(sock, plr);
@ -375,7 +377,6 @@ static void loadPlayer(CNSocket* sock, CNPacketData* data) {
Missions::failInstancedMissions(sock); // auto-fail missions
Buddies::sendBuddyList(sock); // buddy list
Items::checkItemExpire(sock, plr); // vehicle expiration
sendNanoBookSubset(sock, plr); // nanos (post-load)
plr->initialLoadDone = true;
}