mirror of
https://github.com/yuzu-emu/yuzu.git
synced 2024-12-30 23:01:04 +00:00
d7c532d889
There are still some other issues not addressed here, but it's a start. Workarounds for false-positive reports: - `RasterizerAccelerated`: Put a gigantic array behind a `unique_ptr`, because UBSan has a [hardcoded limit](https://stackoverflow.com/questions/64531383/c-runtime-error-using-fsanitize-undefined-object-has-a-possibly-invalid-vp) of how big it thinks objects can be, specifically when dealing with offset-to-top values used with multiple inheritance. Hopefully this doesn't have a performance impact. - `QueryCacheBase::QueryCacheBase`: Avoid an operation that UBSan thinks is UB even though it at least arguably isn't. See the link in the comment for more information. Fixes for correct reports: - `PageTable`, `Memory`: Use `uintptr_t` values instead of pointers to avoid UB from pointer overflow (when pointer arithmetic wraps around the address space). - `KScheduler::Reload`: `thread->GetOwnerProcess()` can be `nullptr`; avoid calling methods on it in this case. (The existing code returns a garbage reference to a field, which is then passed into `LoadWatchpointArray`, and apparently it's never used, so it's harmless in practice but still triggers UBSan.) - `KAutoObject::Close`: This function calls `this->Destroy()`, which overwrites the beginning of the object with junk (specifically a free list pointer). Then it calls `this->UnregisterWithKernel()`. UBSan complains about a type mismatch because the vtable has been overwritten, and I believe this is indeed UB. `UnregisterWithKernel` also loads `m_kernel` from the 'freed' object, which seems to be technically safe (the overwriting doesn't extend as far as that field), but seems dubious. Switch to a `static` method and load `m_kernel` in advance.
137 lines
4.5 KiB
C++
137 lines
4.5 KiB
C++
// SPDX-FileCopyrightText: Copyright 2019 yuzu Emulator Project
|
|
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
|
|
#pragma once
|
|
|
|
#include <atomic>
|
|
|
|
#include "common/common_types.h"
|
|
#include "common/virtual_buffer.h"
|
|
|
|
namespace Common {
|
|
|
|
enum class PageType : u8 {
|
|
/// Page is unmapped and should cause an access error.
|
|
Unmapped,
|
|
/// Page is mapped to regular memory. This is the only type you can get pointers to.
|
|
Memory,
|
|
/// Page is mapped to regular memory, but inaccessible from CPU fastmem and must use
|
|
/// the callbacks.
|
|
DebugMemory,
|
|
/// Page is mapped to regular memory, but also needs to check for rasterizer cache flushing and
|
|
/// invalidation
|
|
RasterizerCachedMemory,
|
|
};
|
|
|
|
/**
|
|
* A (reasonably) fast way of allowing switchable and remappable process address spaces. It loosely
|
|
* mimics the way a real CPU page table works.
|
|
*/
|
|
struct PageTable {
|
|
struct TraversalEntry {
|
|
u64 phys_addr{};
|
|
std::size_t block_size{};
|
|
};
|
|
|
|
struct TraversalContext {
|
|
u64 next_page{};
|
|
u64 next_offset{};
|
|
};
|
|
|
|
/// Number of bits reserved for attribute tagging.
|
|
/// This can be at most the guaranteed alignment of the pointers in the page table.
|
|
static constexpr int ATTRIBUTE_BITS = 2;
|
|
|
|
/**
|
|
* Pair of host pointer and page type attribute.
|
|
* This uses the lower bits of a given pointer to store the attribute tag.
|
|
* Writing and reading the pointer attribute pair is guaranteed to be atomic for the same method
|
|
* call. In other words, they are guaranteed to be synchronized at all times.
|
|
*/
|
|
class PageInfo {
|
|
public:
|
|
/// Returns the page pointer
|
|
[[nodiscard]] uintptr_t Pointer() const noexcept {
|
|
return ExtractPointer(raw.load(std::memory_order_relaxed));
|
|
}
|
|
|
|
/// Returns the page type attribute
|
|
[[nodiscard]] PageType Type() const noexcept {
|
|
return ExtractType(raw.load(std::memory_order_relaxed));
|
|
}
|
|
|
|
/// Returns the page pointer and attribute pair, extracted from the same atomic read
|
|
[[nodiscard]] std::pair<uintptr_t, PageType> PointerType() const noexcept {
|
|
const uintptr_t non_atomic_raw = raw.load(std::memory_order_relaxed);
|
|
return {ExtractPointer(non_atomic_raw), ExtractType(non_atomic_raw)};
|
|
}
|
|
|
|
/// Returns the raw representation of the page information.
|
|
/// Use ExtractPointer and ExtractType to unpack the value.
|
|
[[nodiscard]] uintptr_t Raw() const noexcept {
|
|
return raw.load(std::memory_order_relaxed);
|
|
}
|
|
|
|
/// Write a page pointer and type pair atomically
|
|
void Store(uintptr_t pointer, PageType type) noexcept {
|
|
raw.store(pointer | static_cast<uintptr_t>(type));
|
|
}
|
|
|
|
/// Unpack a pointer from a page info raw representation
|
|
[[nodiscard]] static uintptr_t ExtractPointer(uintptr_t raw) noexcept {
|
|
return raw & (~uintptr_t{0} << ATTRIBUTE_BITS);
|
|
}
|
|
|
|
/// Unpack a page type from a page info raw representation
|
|
[[nodiscard]] static PageType ExtractType(uintptr_t raw) noexcept {
|
|
return static_cast<PageType>(raw & ((uintptr_t{1} << ATTRIBUTE_BITS) - 1));
|
|
}
|
|
|
|
private:
|
|
std::atomic<uintptr_t> raw;
|
|
};
|
|
|
|
PageTable();
|
|
~PageTable() noexcept;
|
|
|
|
PageTable(const PageTable&) = delete;
|
|
PageTable& operator=(const PageTable&) = delete;
|
|
|
|
PageTable(PageTable&&) noexcept = default;
|
|
PageTable& operator=(PageTable&&) noexcept = default;
|
|
|
|
bool BeginTraversal(TraversalEntry& out_entry, TraversalContext& out_context,
|
|
u64 address) const;
|
|
bool ContinueTraversal(TraversalEntry& out_entry, TraversalContext& context) const;
|
|
|
|
/**
|
|
* Resizes the page table to be able to accommodate enough pages within
|
|
* a given address space.
|
|
*
|
|
* @param address_space_width_in_bits The address size width in bits.
|
|
* @param page_size_in_bits The page size in bits.
|
|
*/
|
|
void Resize(std::size_t address_space_width_in_bits, std::size_t page_size_in_bits);
|
|
|
|
std::size_t GetAddressSpaceBits() const {
|
|
return current_address_space_width_in_bits;
|
|
}
|
|
|
|
/**
|
|
* Vector of memory pointers backing each page. An entry can only be non-null if the
|
|
* corresponding attribute element is of type `Memory`.
|
|
*/
|
|
VirtualBuffer<PageInfo> pointers;
|
|
VirtualBuffer<u64> blocks;
|
|
|
|
VirtualBuffer<u64> backing_addr;
|
|
|
|
std::size_t current_address_space_width_in_bits{};
|
|
|
|
u8* fastmem_arena{};
|
|
|
|
std::size_t page_size{};
|
|
};
|
|
|
|
} // namespace Common
|