OpenPunk/yuzu

mirror of https://github.com/yuzu-emu/yuzu.git synced 2024-11-16 03:40:03 +00:00

Author	SHA1	Message	Date
ReinUsesLisp	3e03391a49	vk_buffer_cache: Remove unused function	2021-01-15 02:58:55 -03:00
ReinUsesLisp	be8fd5490e	vulkan_common: Silence missing initializer warnings Silence warnings explicitly initializing all members on construction.	2021-01-15 02:55:11 -03:00
ReinUsesLisp	ba2ea7eeac	vulkan_device: Enable shaderStorageImageMultisample conditionally Fix Vulkan initialization on ANV.	2021-01-15 02:47:05 -03:00
ReinUsesLisp	22be115eb2	astc: Increase integer encoded vector size Invalid ASTC textures seem to write more bytes here, increase the size to something that can't make us push out of bounds.	2021-01-15 02:24:36 -03:00
ReinUsesLisp	0ec71b78fb	astc: Return zero on out of bound bits Avoid out of bound reads on invalid ASTC textures. Games can bind invalid textures that make us read or write out of bounds.	2021-01-15 02:24:36 -03:00
ReinUsesLisp	d9a15a935b	vulkan_device: Remove requirement on shaderStorageImageMultisample yuzu doesn't currently emulate MS image stores. Requiring this makes no sense for now. Fixes ANV not booting any games on Vulkan.	2021-01-13 06:21:33 -03:00
ReinUsesLisp	a4bfae1b55	buffer_cache/buffer_base: Add a range tracking buffer container It keeps track of the modified CPU and GPU ranges on a CPU page granularity, notifying the given rasterizer about state changes in the tracking behavior of the buffer. Use a small vector optimization to store buffers smaller than 256 KiB locally instead of using free store memory allocations.	2021-01-13 04:14:58 -03:00
bunnei	de1a316369	Merge pull request #5311 from ReinUsesLisp/fence-wait vk_fence_manager: Use timeline semaphores instead of spin waits	2021-01-12 21:00:05 -08:00
Levi	7a3c884e39	Merge remote-tracking branch 'upstream/master' into int-flags	2021-01-10 22:09:56 -07:00
bunnei	8eea7c1176	Merge pull request #5231 from ReinUsesLisp/dyn-bindings renderer_vulkan/fixed_pipeline_state: Move enabled bindings to static state	2021-01-08 12:24:46 -08:00
ReinUsesLisp	154a7653f9	vk_fence_manager: Use timeline semaphores instead of spin waits With timeline semaphores we can avoid creating objects. Instead of creating an event, grab the current tick from the scheduler and flush the current command buffer. When the fence has to be queried/waited, we can do so against the master semaphore instead of spinning on an event. If Vulkan supported NVN like events or fences, we could signal from the command buffer and wait for that without splitting things in two separate command buffers.	2021-01-08 02:47:28 -03:00
Ameer J	16392a23cc	remove inaccurate reference Co-authored-by: LC <mathew1800@gmail.com>	2021-01-07 14:33:45 -05:00
ameerj	06cef3355e	fix for nvdec disabled, cleanup host1x	2021-01-07 14:33:45 -05:00
ameerj	2c27127d04	nvdec syncpt incorporation laying the groundwork for async gpu, although this does not fully implement async nvdec operations	2021-01-07 14:33:45 -05:00
MerryMage	21199cb965	vulkan_library: Common::DynamicLibrary::Open is [[nodiscard]] Ignore the return value on __APPLE__ systems as well	2021-01-07 17:37:47 +00:00
MerryMage	aace20afc7	texture_cache: Replace PAGE_SHIFT with PAGE_BITS PAGE_SHIFT is a #define in system headers that leaks into user code on some systems	2021-01-07 16:51:34 +00:00
Morph	e8d40559d5	Merge pull request #5288 from ReinUsesLisp/workaround-garbage gl_texture_cache: Avoid format views on Intel and AMD	2021-01-06 15:39:51 +08:00
bunnei	275b96a0e2	Merge pull request #5289 from ReinUsesLisp/vulkan-device vulkan_common: Move device abstraction to the common directory and allow surfaceless devices	2021-01-05 17:44:56 -08:00
LC	2a6e6306d8	Merge pull request #5292 from ReinUsesLisp/empty-set vk_rasterizer: Skip binding empty descriptor sets on compute	2021-01-04 21:32:57 -05:00
ReinUsesLisp	1ccf805367	vk_rasterizer: Skip binding empty descriptor sets on compute Fixes unit tests where compute shaders had no descriptors in the set, making Vulkan drivers crash when binding an empty set.	2021-01-04 17:56:39 -03:00
ReinUsesLisp	ac1e4734c2	vulkan_device: Allow creating a device without surface	2021-01-04 02:22:22 -03:00
ReinUsesLisp	d235cf3933	renderer_vulkan/nsight_aftermath_tracker: Move to vulkan_common	2021-01-04 02:22:22 -03:00
ReinUsesLisp	3753553b6a	renderer_vulkan: Move device abstraction to vulkan_common	2021-01-04 02:22:22 -03:00
ReinUsesLisp	7d904fef2e	gl_texture_cache: Avoid format views on Intel and AMD Intel and AMD proprietary drivers are incapable of rendering to texture views of different formats than the original texture. Avoid creating these at a cache level. This will consume more memory, emulating them with copies.	2021-01-04 02:06:40 -03:00
ReinUsesLisp	3a49c1a691	gl_texture_cache: Create base images with sRGB This breaks accelerated decoders trying to imageStore into images with sRGB. The decoders are currently disabled so this won't cause issues at runtime.	2021-01-04 01:54:54 -03:00
ReinUsesLisp	974d731926	renderer_vulkan: Rename VKDevice to Device The "VK" prefix predates the "Vulkan" namespace. It was carried around the codebase for consistency. "VKDevice" currently is a bad alias with "VkDevice" (only an upcase character of difference) that can cause confusion. Rename all instances of it.	2021-01-03 17:51:48 -03:00
Rodrigo Locatti	7265e80c12	Merge pull request #5230 from ReinUsesLisp/vulkan-common vulkan_common: Move reusable Vulkan abstractions to a separate directory	2021-01-03 17:38:29 -03:00
Morph	a745d87971	general: Fix various spelling errors	2021-01-02 10:23:41 -05:00
bunnei	25d607f5f6	Merge pull request #5208 from bunnei/service-threads Service threads	2020-12-30 22:06:05 -08:00
ReinUsesLisp	cdbee27692	vulkan_instance: Allow different Vulkan versions and enforce 1.1 For listing the available physical devices we can use Vulkan 1.0. Now that MoltenVK supports 1.1 we can require it for running games. Add missing documentation.	2020-12-31 02:07:34 -03:00
ReinUsesLisp	7344a7c447	vk_device: Use an array to report lacking device limits This makes easier to add and tune the required device limits.	2020-12-31 02:07:34 -03:00
ReinUsesLisp	f687392e6f	vk_device: Stop initialization when device is not suitable VKDevice::IsSuitable was not being called. To address this issue, check suitability before initialization and throw an exception if it fails. By doing this, we can deduplicate some code on queue searches. Previosuly we would first search if a present and graphics queue existed, then on initialization we would search again to find the index.	2020-12-31 02:07:33 -03:00
ReinUsesLisp	53ea06dc17	renderer_vulkan: Remove two step initialization on VKDevice The Vulkan device abstraction either initializes successfully on the constructor or throws a Vulkan exception.	2020-12-31 02:07:33 -03:00
ReinUsesLisp	085adfea00	renderer_vulkan: Throw when enumerating devices fails Report device enumeration errors with exceptions to be consistent with other initialization related function calls. Reduces the amount of code to maintain.	2020-12-31 02:07:33 -03:00
ReinUsesLisp	11f0f7598d	renderer_vulkan: Initialize surface in separate file Move surface initialization code to a separate file. It's unlikely to use this code outside of Vulkan, but keeping platform-specific code (Win32, Xlib, Wayland) in its own translation unit keeps things cleaner.	2020-12-31 02:07:33 -03:00
ReinUsesLisp	dce8720780	renderer_vulkan: Catch and report exceptions Move more Vulkan code to report errors with exceptions and report them through a log before notifying it with an error boolean for backwards compatibility. In the future we can replace the rasterizer two-step initialization to always use exceptions.	2020-12-31 02:07:33 -03:00
ReinUsesLisp	47843b4f09	renderer_vulkan: Create debug callback on separate file and throw Initialize debug callbacks (messenger) from a separate file. This allows sharing code with different backends. Change our Vulkan error handling to use exceptions instead of error codes, simplifying the initialization process.	2020-12-31 02:07:33 -03:00
ReinUsesLisp	25f88d99ce	renderer_vulkan: Move instance initialization to a separate file Simplify Vulkan's backend initialization code by moving it to a separate file, allowing us to initialize a Vulkan instance from different backends.	2020-12-31 02:07:33 -03:00
ReinUsesLisp	d1435009ed	vulkan_common: Rename renderer_vulkan/wrapper.h to vulkan_common/vulkan_wrapper.h Allows sharing Vulkan wrapper code between different rendering backends.	2020-12-31 02:07:14 -03:00
ReinUsesLisp	d937421422	vulkan_common: Move dynamic library load to a separate file Allows us to initialize a Vulkan dynamic library from different backends without duplicating code.	2020-12-31 02:02:48 -03:00
Lioncash	bcafef4b94	half_set: Resolve -Wmaybe-uninitialized warnings	2020-12-30 17:59:42 -05:00
Lioncash	f0d9ab0717	maxwell_to_vk: Initialize usage variable in SurfaceFormat() Silences a -Wmaybe-uninitialized warning	2020-12-30 13:25:03 -05:00
ReinUsesLisp	9764c13d6d	video_core: Rewrite the texture cache The current texture cache has several points that hurt maintainability and performance. It's easy to break unrelated parts of the cache when doing minor changes. The cache can easily forget valuable information about the cached textures by CPU writes or simply by its normal usage.The current texture cache has several points that hurt maintainability and performance. It's easy to break unrelated parts of the cache when doing minor changes. The cache can easily forget valuable information about the cached textures by CPU writes or simply by its normal usage. This commit aims to address those issues.	2020-12-30 03:38:50 -03:00
ReinUsesLisp	9106ac1e6b	video_core: Add a delayed destruction ring abstraction	2020-12-30 02:10:19 -03:00
ReinUsesLisp	21b18057f7	host_shaders: Add Vulkan assembler compute shaders	2020-12-30 02:03:50 -03:00
ReinUsesLisp	87ff58b1d7	host_shaders: Add helper to blit depth stencil fragment shader	2020-12-30 02:02:07 -03:00
ReinUsesLisp	ae5725b709	host_shaders: Add texture color blit fragment shader	2020-12-30 02:00:48 -03:00
ReinUsesLisp	64fbf319f1	host_shaders: Add shaders to present to the swapchain	2020-12-30 01:59:12 -03:00
ReinUsesLisp	82b7daed9c	host_shaders: Add shaders to convert between depth and color images	2020-12-30 01:48:44 -03:00
ReinUsesLisp	dc81a90640	host_shaders: Add compute shader to copy BC4 as RG32UI to RGBA8	2020-12-30 01:47:08 -03:00
ReinUsesLisp	5169ce9fcd	host_shaders: Add shader to render a full screen triangle	2020-12-30 01:44:09 -03:00
ReinUsesLisp	59c46f9de9	host_shaders: Add pitch linear upload compute shader	2020-12-30 01:41:42 -03:00
ReinUsesLisp	12d16248dd	host_shaders: Add block linear upload compute shaders	2020-12-30 01:39:35 -03:00
ReinUsesLisp	f20e18f60d	host_shaders: Add copyright headers to OpenGL present shaders	2020-12-30 01:35:56 -03:00
ReinUsesLisp	95d156a150	video_core/host_shaders: Add support for prebuilt SPIR-V shaders Add support for building SPIR-V shaders from GLSL and generating headers to include the text of those same GLSL shaders to consume from OpenGL.	2020-12-30 01:29:07 -03:00
bunnei	954341763a	gpu: gpu_thread: Ensure MicroProfile is shutdown on exit.	2020-12-28 21:33:34 -08:00
bunnei	4991620f89	video_core: gpu_thread: Do not wait when system is powered down.	2020-12-28 16:33:48 -08:00
bunnei	40571c073f	video_core: gpu: Implement synchronous mode using threaded GPU.	2020-12-28 16:33:48 -08:00
bunnei	14c825bd1c	video_core: gpu: Refactor out synchronous/asynchronous GPU implementations. - We must always use a GPU thread now, even with synchronous GPU.	2020-12-28 16:33:48 -08:00
ReinUsesLisp	661483f313	renderer_vulkan/fixed_pipeline_state: Move enabled bindings to static state Without using VK_EXT_robustness2, we can't consider the 'enabled' (not null) vertex buffers as dynamic state, as this leads to invalid Vulkan state. Move this to static state that is always hashed and compared in the pipeline key. The bits for enabled vertex buffers are moved into the attribute state bitfield. This is not 'correct' as it's not an attribute state, but that struct has bits to spare, and it's used in an array of 32 elements (the exact same number of vertex buffer bindings).	2020-12-25 23:34:38 -03:00
Rodrigo Locatti	0dc4ab42cc	Merge pull request #5226 from ReinUsesLisp/c4715-vc video_core: Enforce C4715 (not all control paths return a value)	2020-12-25 03:11:47 -03:00
ReinUsesLisp	1b9e08ab78	cmake: Always enable Vulkan Removes the unnecesary burden of maintaining separate #ifdef paths and allows us sharing generic Vulkan code across APIs.	2020-12-24 21:07:24 -03:00
ReinUsesLisp	1e191cc837	video_core: Enforce C4715 (not all control paths return a value) Most of the time people write code that always returns a value, terminates execution, throws an exception, or uses an unconventional jump primitive. This is not always true when we build without asserts on mainline builds. To avoid introducing undefined behavior on our most used builds, enforce this warning signalling an error and stopping the build from shipping.	2020-12-24 21:01:23 -03:00
ReinUsesLisp	5dbda22659	vk_shader_decompiler: Silence warning when compiling without asserts	2020-12-24 21:01:09 -03:00
bunnei	37bec068c2	Merge pull request #5157 from lioncash/array-dirty maxwell_3d: Remove unused dirty_pointer array	2020-12-15 00:35:47 -08:00
bunnei	d1a2b3fb18	Merge pull request #5162 from lioncash/copy-shader gl_shader_decompiler: Elide unnecessary copies within DeclareConstantBuffers()	2020-12-10 00:11:11 -08:00
Rodrigo Locatti	3415890dd5	Merge pull request #5164 from lioncash/contains video_core: Make use of ordered container contains() where applicable	2020-12-07 21:55:51 -03:00
Lioncash	09fa1d6a73	video_core: Make use of ordered container contains() where applicable With C++20, we can use the more concise contains() member function instead of comparing the result of the find() call with the end iterator.	2020-12-07 16:30:39 -05:00
Lioncash	45c5b084fd	ast: Improve string concat readability in operator() Provides an in-place format string to make it more pleasant to read.	2020-12-07 16:15:28 -05:00
Lioncash	edcbd47800	gl_shader_decompiler: Elide unnecessary copies within DeclareConstantBuffers() Resolves a -Wrange-loop-analysis warning.	2020-12-07 14:01:52 -05:00
bunnei	5cd051eced	Merge pull request #5149 from comex/xx-map-interval map_interval: Change field order to address uninitialized field warning	2020-12-07 10:14:02 -08:00
Rodrigo Locatti	12f3b13995	Merge pull request #5159 from lioncash/move-amend shader_ir: std::move node within DeclareAmend()	2020-12-07 04:58:01 -03:00
Lioncash	5d2f18fbcd	buffer_block: Mark interface as nodiscard where applicable Prevents logic errors from occurring from unused values.	2020-12-07 01:53:40 -05:00
Lioncash	3954f14c6d	buffer_block: Remove unnecessary includes Reduces the amount of dependencies the header pulls in.	2020-12-07 01:52:16 -05:00
Lioncash	7234f436aa	shader_ir: std::move node within DeclareAmend() Same behavior, but elides an unnecessary atomic reference count increment and decrement.	2020-12-07 00:51:03 -05:00
Lioncash	4c5f5c9bf3	video_core: Remove unnecessary enum class casting in logging messages fmt now automatically prints the numeric value of an enum class member by default, so we don't need to use casts any more. Reduces the line noise a bit.	2020-12-07 00:41:50 -05:00
LC	23aabe85e6	Merge pull request #5152 from comex/xx-override renderer_vulkan: Add missing `override` specifier	2020-12-07 00:07:17 -05:00
LC	69af6ada2f	Merge pull request #5136 from lioncash/video-shadow3 video_core: Resolve more variable shadowing scenarios pt.3	2020-12-07 00:06:53 -05:00
Lioncash	9e7a1f1351	maxwell_3d: Move member variables to end of class Follows our established coding style.	2020-12-06 20:56:00 -05:00
Lioncash	ce0712bf95	maxwell_3d: Resolve -Wdocumentation warning Removes a documentation comment for a non-existent member.	2020-12-06 20:48:12 -05:00
Lioncash	bcc5c4403a	maxwell_3d: Remove unused dirty_pointer array This is unused and removing it shrinks the structure by 3584 bytes.	2020-12-06 20:46:57 -05:00
comex	eea5122d1b	renderer_vulkan: Add missing `override` specifier	2020-12-06 18:38:52 -05:00
comex	b8fbf6969c	map_interval: Change field order to address uninitialized field warning Clang complains about `new_chunk`'s constructor using the then-uninitialized `first_chunk` (even though it's just to get a pointer into it).	2020-12-06 18:37:23 -05:00
comex	d637114c17	video_core: Adjust `NUM` macro to avoid Clang warning The previous definition was: #define NUM(field_name) (sizeof(Maxwell3D::Regs::field_name) / sizeof(u32)) In cases where `field_name` happens to refer to an array, Clang thinks `sizeof(an array value) / sizeof(a type)` is an instance of the idiom where `sizeof` is used to compute an array length. So it thinks the type in the denominator ought to be the array element type, and warns if it isn't, assuming this is a mistake. In reality, `NUM` is not used to get array lengths at all, so there is no mistake. Silence the warning by applying Clang's suggested workaround of parenthesizing the denominator.	2020-12-06 18:24:16 -05:00
comex	a6e6cd5788	maxwell_dma: Rename RenderEnable::Mode::FALSE and TRUE to avoid name conflict On Apple platforms, FALSE and TRUE are defined as macros by <mach/boolean.h>, which is included by various system headers. Note that there appear to be no actual users of the names to fix up.	2020-12-05 17:59:02 -05:00
Lioncash	f95602f152	video_core: Resolve more variable shadowing scenarios pt.3 Cleans out the rest of the occurrences of variable shadowing and makes any further occurrences of shadowing compiler errors.	2020-12-05 16:02:23 -05:00
Lioncash	414a87a4f4	video_core: Resolve more variable shadowing scenarios pt.2 Migrates the video core code closer to enabling variable shadowing warnings as errors. This primarily sorts out shadowing occurrences within the Vulkan code.	2020-12-05 06:39:35 -05:00
bunnei	e6a896c4bd	Merge pull request #5124 from lioncash/video-shadow video_core: Resolve more variable shadowing scenarios	2020-12-05 00:48:08 -08:00
bunnei	63419e144f	Merge pull request #5127 from FearlessTobi/port-5617 Port citra-emu/citra#5617: "Fix telemetry-related exit crash from use-after-free"	2020-12-04 21:57:40 -08:00
FearlessTobi	37d672bf08	Fix telemetry-related exit crash from use-after-free Co-Authored-By: xperia64 <xperia64@users.noreply.github.com>	2020-12-05 02:42:50 +01:00
Lioncash	94af77aa7c	codec: Remove deprecated usage of AVCodecContext::refcounted_frames This was only necessary for use with the avcodec_decode_video2/avcoded_decode_audio4 APIs which are also deprecated. Given we use avcodec_send_packet/avcodec_receive_frame, this isn't necessary, this is even indicated directly within the FFmpeg API changes document here on 2017-09-26: https://github.com/FFmpeg/FFmpeg/blob/master/doc/APIchanges#L410 This prevents our code from breaking whenever we update to a newer version of FFmpeg in the future if they ever decide to fully remove this API member.	2020-12-04 16:23:13 -05:00
Lioncash	677a8b208d	video_core: Resolve more variable shadowing scenarios Resolves variable shadowing scenarios up to the end of the OpenGL code to make it nicer to review. The rest will be resolved in a following commit.	2020-12-04 16:19:09 -05:00
bunnei	fad38ec6e8	Merge pull request #5064 from lioncash/node-shadow node: Eliminate variable shadowing	2020-12-04 00:45:33 -08:00
Lioncash	edd8208779	node: Mark member functions as [[nodiscard]] where applicable Prevents logic bugs from accidentally ignoring the return value.	2020-12-03 16:03:34 -05:00
Lioncash	7cf34c3637	node: Eliminate variable shadowing	2020-12-03 15:59:38 -05:00
Lioncash	cf9767c608	vp9/vic: Resolve pessimizing moves Removes the usage of moves that don't result in behavior different from a copy, or otherwise would prevent copy elision from occurring.	2020-12-03 12:33:07 -05:00
bunnei	9abb23cd27	Merge pull request #5002 from ameerj/nvdec-frameskip nvdec: Queue and display all decoded frames, cleanup decoders	2020-12-02 15:55:15 -08:00
bunnei	7b4a213603	Merge pull request #5013 from ReinUsesLisp/vk-early-z vk_shader_decompiler: Implement force early fragment tests	2020-11-30 11:11:07 -08:00
comex	4681e1ea9e	codec: Fix `pragma GCC diagnostic pop` missing corresponding push	2020-11-26 16:35:42 -05:00
ReinUsesLisp	2ccf85a910	vk_shader_decompiler: Implement force early fragment tests Force early fragment tests when the 3D method is enabled. The established pipeline cache takes care of recompiling if needed. This is implemented only on Vulkan to avoid invalidating the shader cache on OpenGL.	2020-11-26 17:52:26 -03:00
ameerj	979b602738	Limit queue size to 10 frames Workaround for ZLA, which seems to decode and queue twice as many frames as it displays.	2020-11-26 14:04:06 -05:00
bunnei	322349e8cc	Merge pull request #4975 from comex/invalid-syncpoint-id nvdrv, video_core: Don't index out of bounds when given invalid syncpoint ID	2020-11-26 01:27:24 -08:00
ameerj	c9e3abe206	Address PR feedback remove some redundant moves, make deleter match naming guidelines. Co-Authored-By: LC <712067+lioncash@users.noreply.github.com>	2020-11-26 00:18:26 -05:00
Rodrigo Locatti	0e15c68f54	Merge pull request #4976 from comex/poll-events Overhaul EmuWindow::PollEvents to fix yuzu-cmd calling SDL_PollEvents off main thread	2020-11-25 20:44:53 -03:00
ameerj	eab041866b	Queue decoded frames, cleanup decoders	2020-11-25 17:10:44 -05:00
ameerj	d52ee6d0a7	cleanup unneeded comments and newlines	2020-11-25 14:46:08 -05:00
ameerj	e87670ee48	Refactor MaxwellToSpirvComparison. Use Common::BitCast Co-Authored-By: Rodrigo Locatti <reinuseslisp@airmail.cc>	2020-11-25 00:33:20 -05:00
ameerj	1dbf71ceb3	Address PR feedback from Rein	2020-11-24 22:46:45 -05:00
ameerj	9014861858	vulkan_renderer: Alpha Test Culling Implementation Used by various textures in many titles, e.g. SSBU menu.	2020-11-24 22:46:45 -05:00
comex	e8b2fd21d8	nvdrv, video_core: Don't index out of bounds when given invalid syncpoint ID - Use .at() instead of raw indexing when dealing with untrusted indices. - For the special case of WaitFence with syncpoint id UINT32_MAX, instead of crashing, log an error and ignore. This is what I get when running Super Mario Maker 2.	2020-11-24 12:59:41 -05:00
Rodrigo Locatti	fbda5e9ec9	Merge pull request #3681 from lioncash/component decoder/image: Fix incorrect G24R8 component sizes in GetComponentSize()	2020-11-24 04:38:03 -03:00
comex	994f497781	Overhaul EmuWindow::PollEvents to fix yuzu-cmd calling SDL_PollEvents off main thread EmuWindow::PollEvents was called from the GPU thread (or the CPU thread in sync-GPU mode) when swapping buffers. It had three implementations: - In GRenderWindow, it didn't actually poll events, just set a flag and emit a signal to indicate that a frame was displayed. - In EmuWindow_SDL2_Hide, it did nothing. - In EmuWindow_SDL2, it did call SDL_PollEvents, but this is wrong because SDL_PollEvents is supposed to be called on the thread that set up video - in this case, the main thread, which was sleeping in a busyloop (regardless of whether sync-GPU was enabled). On macOS this causes a crash. To fix this: - Rename EmuWindow::PollEvents to OnFrameDisplayed, and give it a default implementation that does nothing. - In EmuWindow_SDL2, do not override OnFrameDisplayed, but instead have the main thread call SDL_WaitEvent in a loop.	2020-11-23 17:58:49 -05:00
Morph	e13a91fa9b	Merge pull request #4954 from lioncash/compare gl_rasterizer: Make floating-point literal a float	2020-11-22 09:55:23 +08:00
bunnei	5502f39125	Merge pull request #4955 from lioncash/move3 async_shaders: std::move data within QueueVulkanShader()	2020-11-21 01:21:08 -08:00
LC	d88baa746b	Merge pull request #4957 from ReinUsesLisp/alpha-test-rt gl_rasterizer: Remove warning of untested alpha test	2020-11-20 21:19:06 -05:00
ReinUsesLisp	acc14d233f	gl_rasterizer: Remove warning of untested alpha test Alpha test has been proven to only affect the first render target.	2020-11-20 23:17:40 -03:00
bunnei	b00f4abe36	Merge pull request #4953 from lioncash/shader-shadow shader_bytecode: Eliminate variable shadowing	2020-11-20 16:58:14 -08:00
Lioncash	01db5cf203	async_shaders: emplace threads into the worker thread vector Same behavior, but constructs the threads in place instead of moving them.	2020-11-20 04:46:56 -05:00
Lioncash	ba3916fc67	async_shaders: Simplify implementation of GetCompletedWork() This is equivalent to moving all the contents and then clearing the vector. This avoids a redundant allocation.	2020-11-20 04:44:44 -05:00
Lioncash	3fcc98e11a	async_shaders: Simplify moving data into the pending queue	2020-11-20 04:41:29 -05:00
Lioncash	5b441fa25d	async_shaders: std::move data within QueueVulkanShader() Same behavior, but avoids redundant copies. While we're at it, we can simplify the pushing of the parameters into the pending queue.	2020-11-20 04:38:18 -05:00
Lioncash	8469b76630	gl_rasterizer: Make floating-point literal a float Gets rid of an unnecessary expansion from float to double.	2020-11-20 04:24:33 -05:00
Lioncash	b7cd5d742e	shader_bytecode: Make use of [[nodiscard]] where applicable Ensures that all queried values are made use of.	2020-11-20 02:20:37 -05:00
Lioncash	56ecafc204	shader_bytecode: Eliminate variable shadowing	2020-11-20 02:13:45 -05:00
Rodrigo Locatti	1889b641d9	Merge pull request #4308 from ReinUsesLisp/maxwell-3d-funcs maxwell_3d: Move code to separate functions and insert instead of push_back	2020-11-20 01:57:22 -03:00
Lioncash	70812ec57b	rasterizer_interface: Make use of [[nodiscard]] where applicable	2020-11-17 07:19:13 -05:00
Lioncash	a78021580d	render_base: Make use of [[nodiscard]] where applicable	2020-11-17 07:19:12 -05:00
Lioncash	b928fca114	gpu: Make use of [[nodiscard]] where applicable	2020-11-17 07:19:09 -05:00
ReinUsesLisp	622830f4e1	maxwell_3d: Use insert instead of loop push_back This reduces the overhead of bounds checking on each element. It won't reduce the cost of allocation because usually this vector's capacity is usually large enough to hold whatever we push to it.	2020-11-11 19:52:19 -03:00
ReinUsesLisp	9ea8cffe35	maxwell_3d: Move code to separate functions Deduplicate some code and put it in separate functions so it's easier to understand and profile.	2020-11-11 19:52:19 -03:00
bunnei	dc5396a466	video_core: dma_pusher: Remove integrity check on command lists. - This seems to cause softlocks in Breath of the Wild.	2020-11-07 00:08:19 -08:00
bunnei	91a45834fd	Merge pull request #4891 from lioncash/clang2 General: Fix clang build	2020-11-06 10:33:13 -08:00
bunnei	a111a9ae2c	Merge pull request #4854 from ReinUsesLisp/cube-array-shadow shader: Partially implement texture cube array shadow	2020-11-05 16:25:00 -08:00
Lioncash	6f006d051e	General: Fix clang build Allows building on clang to work again	2020-11-05 10:07:16 -05:00
bunnei	087f52e872	Merge pull request #4858 from lioncash/initializer General: Resolve a few missing initializer warnings	2020-11-04 12:10:10 -08:00
Chloe	6bbbbe8f85	Merge pull request #4869 from bunnei/improve-gpu-sync Improvements to GPU synchronization & various refactoring	2020-11-04 18:36:55 +11:00
bunnei	4bfa411ddc	Merge pull request #4874 from lioncash/nodiscard2 nvdec: Make use of [[nodiscard]] where applicable	2020-11-03 16:34:07 -08:00
Lioncash	4f0f481f63	nvdec: Make use of [[nodiscard]] where applicable Prevents bugs from occurring where the results of a function are accidentally discarded	2020-11-02 02:45:15 -05:00
bunnei	1089d76736	Merge pull request #4865 from ameerj/async-threadcount async_shaders: Increase Async worker thread count for >8 thread cpus	2020-11-01 01:54:01 -07:00
bunnei	c6e1c46ac7	video_core: dma_pusher: Add support for integrity checks. - Log corrupted command lists, rather than crash.	2020-11-01 01:52:38 -07:00
bunnei	c64545d07a	video_core: dma_pusher: Add support for prefetched command lists.	2020-11-01 01:52:38 -07:00
bunnei	6053b95552	video_core: gpu: Implement WaitFence and IncrementSyncPoint.	2020-11-01 01:52:37 -07:00
bunnei	98f68d06f1	Merge pull request #4853 from ReinUsesLisp/fcmp-imm shader/arithmetic: Implement FCMP immediate + register variant	2020-10-31 01:25:02 -07:00
Lioncash	12eeffcb7c	vp9: Be explicit with copy and move operators It's deprecated in the language to autogenerate these if the destructor for a type is specified, so we can explicitly specify how we want these to be generated.	2020-10-29 22:57:35 -04:00
Lioncash	0d713cf8eb	vp9: Mark functions with [[nodiscard]] where applicable Prevents values from mistakenly being discarded in cases where it's a bug to do so.	2020-10-29 22:57:32 -04:00
Lioncash	badea3b301	vp9: Provide a default initializer for "hidden" member The API of VP9 exposes a WasFrameHidden() function which accesses this member. Given the constructor previously didn't initialize this member, it's a potential vector for an uninitialized read. Instead, we can initialize this to a deterministic value to prevent that from occurring.	2020-10-29 22:35:55 -04:00
Lioncash	f8543249f0	vp9: Make some member functions internally linked These helper functions don't directly modify any member state and can be hidden from view.	2020-10-29 22:34:46 -04:00
Lioncash	5553bd3ba2	General: Resolve a few missing initializer warnings Resolves a few -Wmissing-initializer warnings.	2020-10-29 19:37:07 -04:00
bunnei	ef29bf4515	Merge pull request #4837 from lioncash/nvdec-2 nvdec: Minor tidying up	2020-10-29 12:28:07 -07:00
ameerj	3620206136	async_shaders: Increase Async worker thread count for 8+ thread cpus Adds 1 async worker thread for every 2 available threads above 8	2020-10-29 14:16:45 -04:00
bunnei	c6d001c94f	Merge pull request #4838 from lioncash/syncmgr sync_manager: Amend parameter order of calls to SyncptIncr constructor	2020-10-28 22:49:22 -07:00
bunnei	94eca09cf6	video_core: cdma_pusher: Add missing LOG_DEBUG field in ExecuteCommand.	2020-10-28 16:47:08 -07:00
ReinUsesLisp	657771bdcb	shader: Partially implement texture cube array shadow This implements texture cube arrays with shadow comparisons but doesn't fix the asserts related to it. Fixes out of bounds reads on swizzle constructors and makes them use bounds checked ::at instead of the unsafe operator[].	2020-10-28 17:12:40 -03:00
ReinUsesLisp	44b552be71	shader/arithmetic: Implement FCMP immediate + register variant Trivially add the encoding for this.	2020-10-28 17:05:41 -03:00
LC	978e7897a3	Merge pull request #4848 from ReinUsesLisp/type-limits video_core: Enforce -Werror=type-limits	2020-10-28 03:16:10 -04:00
ReinUsesLisp	79da90cea8	video_core: Enforce -Wredundant-move and -Wpessimizing-move Silence three warnings and make them errors to avoid introducing more in the future.	2020-10-28 02:44:50 -03:00
ReinUsesLisp	4a451e5849	video_core: Enforce -Werror=type-limits Silences one warning and avoids introducing more in the future.	2020-10-28 02:37:47 -03:00
Lioncash	047e77e2f0	sync_manager: Amend parameter order of calls to SyncptIncr constructor Corrects some cases where the arguments would be incorrectly swapped.	2020-10-27 03:22:57 -04:00
Lioncash	cce14b4cd7	h264: Make WriteUe take a u32 Enforces the type of the desired value in calling code.	2020-10-27 03:21:53 -04:00
Lioncash	6291975731	vp9: std::move buffer within ComposeFrameHeader() We can move the buffer here to avoid a heap reallocation	2020-10-27 02:27:31 -04:00
Lioncash	00decfbb07	vp9: Remove dead code	2020-10-27 02:26:17 -04:00
Lioncash	111802bbbb	vp9: Join declarations with assignments	2020-10-27 02:26:03 -04:00
Lioncash	3b5d5fa86f	vp9: Remove pessimizing moves The move will already occur without std::move.	2020-10-27 02:21:40 -04:00
Lioncash	dcc26c54a5	vp9: Resolve variable shadowing	2020-10-27 02:20:17 -04:00
Lioncash	c04203b786	nvdec: Tidy up header includes Prevents a few unnecessary inclusions.	2020-10-27 02:16:42 -04:00
ameerj	eb67a45ca8	video_core: NVDEC Implementation This commit aims to implement the NVDEC (Nvidia Decoder) functionality, with video frame decoding being handled by the FFmpeg library. The process begins with Ioctl commands being sent to the NVDEC and VIC (Video Image Composer) emulated devices. These allocate the necessary GPU buffers for the frame data, along with providing information on the incoming video data. A Submit command then signals the GPU to process and decode the frame data. To decode the frame, the respective codec's header must be manually composed from the information provided by NVDEC, then sent with the raw frame data to the ffmpeg library. Currently, H264 and VP9 are supported, with VP9 having some minor artifacting issues related mainly to the reference frame composition in its uncompressed header. Async GPU is not properly implemented at the moment. Co-Authored-By: David <25727384+ogniK5377@users.noreply.github.com>	2020-10-26 23:07:36 -04:00
bunnei	3e46934442	Merge pull request #4706 from ReinUsesLisp/cmake-host-shaders video_core: Fix instances where msbuild always regenerated host shaders	2020-10-23 10:01:16 -07:00
Lioncash	678d012c2c	video_core: Conditially activate relevant compiler warnings These compiler flags aren't shared with clang, so specifying these flags unconditionally can lead to a bit of warning spam. While we're in the area, we can also enable -Wunused-but-set-parameter given this is almost always a bug.	2020-10-20 20:28:25 -04:00
ReinUsesLisp	f21a189148	gl_arb_decompiler: Implement robust buffer operations This emulates the behavior we get on GLSL with regular SSBOs with a pointer + length pair. It aims to be consistent with the crashes we might get. Out of bounds stores are ignored. Atomics are ignored and return zero. Reads return zero.	2020-10-20 03:34:32 -03:00
bunnei	f1ead11df7	Merge pull request #4204 from ReinUsesLisp/vulkan-1.0 renderer_vulkan: Create and properly use Vulkan 1.0 instances when 1.1 is not available	2020-10-19 14:18:54 -07:00
bunnei	743fe1aea3	Merge pull request #4782 from ReinUsesLisp/remove-dyn-primitive vk_graphics_pipeline: Manage primitive topology as fixed state	2020-10-17 22:14:17 -07:00
bunnei	d47ac3ce09	Merge pull request #4772 from goldenx86/block-rdna vk_device: Block VK_EXT_extended_dynamic_state for RDNA devices	2020-10-14 17:51:39 -07:00
ReinUsesLisp	e4e0abc418	vk_graphics_pipeline: Manage primitive topology as fixed state Vulkan has requirements for primitive topologies that don't play nicely with yuzu's. Since it's only 4 bits, we can move it to fixed state without changing the size of the pipeline key. - Fixes a regression on recent Nvidia drivers on Fire Emblem: Three Houses.	2020-10-13 04:08:33 -03:00
bunnei	4c348f4069	Merge pull request #4766 from ReinUsesLisp/tmml-cube shader/texture: Implement CUBE texture type for TMML and fix arrays	2020-10-12 12:53:57 -07:00
ReinUsesLisp	e1600b0962	video_core: Enforce -Wclass-memaccess	2020-10-09 16:46:11 -03:00
LC	61b246a3a9	Merge pull request #4771 from ReinUsesLisp/warn-unused-var video_core: Enforce -Wunused-variable and -Wunused-but-set-variable	2020-10-08 21:10:31 -04:00
goldenx86	0120e5b1d9	vk_device: Block VK_EXT_extended_dynamic_state for RDNA devices RDNA devices seem to crash when using VK_EXT_extended_dynamic_state in the latest 20.9.2 proprietary Windows drivers. As a workaround, for now we block device names corresponding to current RDNA released products.	2020-10-08 21:27:49 -03:00
ReinUsesLisp	dffaffaac1	shader/texture: Implement CUBE texture type for TMML and fix arrays TMML takes an array argument that has no known meaning, this one appears as the first component in gpr8 followed by s, t and r. Skip this component when arrays are being used. Also implement CUBE texture types. - Used by Pikmin 3: Deluxe Demo.	2020-10-07 23:17:46 -03:00
ReinUsesLisp	cd3e959f23	renderer_vulkan/wrapper: Fix physical device sorting The old code had a sort function that was invalid and it didn't work as expected when the base vector had a different order (e.g. renderdoc was attached). This sorts devices as expected and fixes a debug assert on MSVC.	2020-10-07 17:13:22 -03:00
ReinUsesLisp	2a24b1c973	video_core: Enforce -Wunused-variable and -Wunused-but-set-variable	2020-10-02 21:19:35 -03:00
Matías Locatti	d7843b8ef2	Remove ext_extended_dynamic_state blacklist Latest AMD 20.9.2 driver fixed this, there's no reason to keep it blocked, as the previous stable signed driver release doesn't include the extension.	2020-09-30 03:13:38 -03:00
Rodrigo Locatti	e5a1e0a76d	Merge pull request #4724 from lat9nq/fix-vulkan-nvidia-allocate-2 vk_stream_buffer: Fix initializing Vulkan with NVIDIA on Linux	2020-09-26 23:52:49 +00:00
bunnei	442096298e	Merge pull request #4703 from lioncash/desig7 shader/registry: Make use of designated initializers where applicable	2020-09-26 15:23:15 -07:00
lat9nq	ca26fd0f42	vk_stream_buffer: Fix initializing Vulkan with NVIDIA on Linux The previous fix only partially solved the issue, as only certain GPUs that needed 9 or less MiB subtracted would work (i.e. GTX 980 Ti, GT 730). This takes from DXVK's example to divide `heap_size` by 2 to determine `allocable_size`. Additionally tested on my Quadro K4200, which previously required setting it to 12 to boot.	2020-09-25 17:42:59 -04:00
Lioncash	940d85241b	vk_command_pool: Move definition of Pool into the cpp file Allows the implementation details to be changed without recompiling any files that include this header.	2020-09-25 00:15:52 -04:00
Lioncash	4ed4bba305	vk_command_pool: Make use of override on destructor	2020-09-25 00:14:10 -04:00
Lioncash	e0f2db4376	vk_command_pool: Add missing header guard	2020-09-25 00:12:45 -04:00
Levi Behunin	bc69cc1511	More forgetting... duh	2020-09-24 22:12:13 -06:00
bunnei	2634e3c6eb	Merge pull request #4711 from lioncash/move5 arithmetic_integer_immediate: Make use of std::move where applicable	2020-09-24 21:02:42 -07:00
Levi Behunin	24c1bb3842	Forgot to apply suggestion here as well	2020-09-24 21:58:51 -06:00
Levi Behunin	a19dc3bf00	Address Comments	2020-09-24 21:52:23 -06:00
Levi Behunin	d53b79ff5c	Start of Integer flags implementation	2020-09-24 16:40:06 -06:00
Lioncash	e3a615a616	arithmetic_integer_immediate: Make use of std::move where applicable Same behavior, minus any redundant atomic reference count increments and decrements.	2020-09-24 13:28:45 -04:00
ReinUsesLisp	67af0323f0	video_core: Fix instances where msbuild always regenerated host shaders When HEADER_GENERATOR was included in the DEPENDS section of custom commands, msbuild assumed this was always modified. Changing this file is not common so we can remove it from there.	2020-09-23 22:27:17 -03:00
bunnei	d66b897a6d	Merge pull request #4674 from ReinUsesLisp/timeline-semaphores renderer_vulkan: Make unconditional use of VK_KHR_timeline_semaphore	2020-09-23 18:24:27 -07:00
Lioncash	77532ebde3	shader/registry: Silence a -Wshadow warning	2020-09-23 15:10:25 -04:00
Lioncash	cd6f4f7eed	shader/registry: Remove unnecessary namespace qualifiers Using statements already make these unnecessary.	2020-09-23 15:08:34 -04:00
Lioncash	ffeb4ef83e	shader/registry: Make use of designated initializers where applicable Same behavior, less repetition.	2020-09-23 15:06:25 -04:00
Lioncash	0dc6967ff1	control_flow: emplace elements in place within TryQuery() Places data structures where they'll eventually be moved to to avoid needing to even move them in the first place.	2020-09-22 22:54:36 -04:00
Lioncash	fcd0145eb5	control_flow: Make use of std::move in InsertBranch() Avoids unnecessary atomic increments and decrements.	2020-09-22 22:48:09 -04:00
Lioncash	ff45c39578	General: Make use of std::nullopt where applicable Allows some implementations to avoid completely zeroing out the internal buffer of the optional, and instead only set the validity byte within the structure. This also makes it consistent how we return empty optionals.	2020-09-22 17:32:33 -04:00
ReinUsesLisp	7003090187	renderer_opengl: Remove emulated mailbox presentation Emulated mailbox presentation was causing performance issues on Nvidia's OpenGL driver. Remove it.	2020-09-20 16:29:41 -03:00
ReinUsesLisp	4f5bbe56ba	vk_query_cache: Hack counter destructor to avoid reserving queries This is a hack to destroy all HostCounter instances before the base class destructor is called. The query cache should be redesigned to have a proper ownership model instead of using shared pointers. For now, destroy the host counter hierarchy from the derived class destructor.	2020-09-19 01:47:29 -03:00
ReinUsesLisp	58b0ae84b5	renderer_vulkan: Make unconditional use of VK_KHR_timeline_semaphore This reworks how host<->device synchronization works on the Vulkan backend. Instead of "protecting" resources with a fence and signalling these as free when the fence is known to be signalled by the host GPU, use timeline semaphores. Vulkan timeline semaphores allow use to work on a subset of D3D12 fences. As far as we are concerned, timeline semaphores are a value set by the host or the device that can be waited by either of them. Taking advantange of this, we can have a monolithically increasing atomic value for each submission to the graphics queue. Instead of protecting resources with a fence, we simply store the current logical tick (the atomic value stored in CPU memory). When we want to know if a resource is free, it can be compared to the current GPU tick. This greatly simplifies resource management code and the free status of resources should have less false negatives. To workaround bugs in validation layers, when these are attached there's a thread waiting for timeline semaphores.	2020-09-19 01:46:37 -03:00
Lioncash	91bca9eb0b	fermi_2d: Make use of designated initializers Same behavior, less repetition. We can also ensure all members of Config are initialized.	2020-09-18 13:55:21 -04:00
Rodrigo Locatti	31461589c5	Merge pull request #4672 from lioncash/narrowing decoder/texture: Eliminate narrowing conversion in GetTldCode()	2020-09-17 21:17:54 +00:00
Lioncash	4944d48ee8	decode/image: Eliminate switch fallthrough in DecodeImage() Fortunately this didn't result in any issues, given the block that code was falling through to would immediately break.	2020-09-17 15:12:18 -04:00
Lioncash	ffc66f089d	decoder/texture: Eliminate narrowing conversion in GetTldCode() The assignment was previously truncating a u64 value to a bool.	2020-09-17 15:04:17 -04:00
ReinUsesLisp	eb914b6c50	video_core: Enforce -Werror=switch This forces us to fix all -Wswitch warnings in video_core.	2020-09-16 17:48:01 -03:00
ReinUsesLisp	9e87193725	video_core: Remove all Core::System references in renderer Now that the GPU is initialized when video backends are initialized, it's no longer needed to query components once the game is running: it can be done when yuzu is booting. This allows us to pass components between constructors and in the process remove all Core::System references in the video backend.	2020-09-06 05:28:48 -03:00
bunnei	94a25b75a0	Merge pull request #4611 from lioncash/xbyak2 externals: Update Xbyak to 5.96	2020-09-03 20:24:27 -04:00
bunnei	39319f09d8	Merge pull request #4575 from lioncash/async async_shaders: Mark getters as const member functions	2020-09-03 11:34:30 -04:00
ReinUsesLisp	c573920c01	vk_device: Fix driver id check on AMD for VK_EXT_extended_dynamic_state 'driver_id' can only be known on Vulkan 1.1 after creating a logical device. Move the driver id check to disable VK_EXT_extended_dynamic_state after the logical device is successfully initialized. The Vulkan device will have the extension enabled but it will not be used.	2020-08-30 20:22:48 -03:00
Lioncash	a5dcccfdd2	externals: Update Xbyak to 5.96 I made a request on the Xbyak issue tracker to allow some constructors to be constexpr in order to avoid static constructors from needing to execute for some of our register constants. This request was implemented, so this updates Xbyak so that we can make use of it.	2020-08-30 05:09:48 -04:00
ReinUsesLisp	fe90c4fd7b	vk_device: Blacklist AMD proprietary from VK_EXT_extended_dynamic_state Vertex binding's <stride> is bugged on AMD's proprietary drivers when using VK_EXT_extended_dynamic_state. Blacklist it for now while we investigate how to report this issue to AMD.	2020-08-28 19:14:57 -03:00
bunnei	9864da7d43	Merge pull request #4524 from lioncash/memory-log shader/memory: Amend UNIMPLEMENTED_IF_MSG without a message	2020-08-27 00:16:10 -04:00
bunnei	1bb8c27a70	Merge pull request #4569 from ReinUsesLisp/glsl-cmake video_core/host_shaders: Add CMake integration for string shaders	2020-08-26 22:57:39 -04:00
bunnei	1e2a92918b	Merge pull request #4555 from ReinUsesLisp/fix-primitive-topology vk_state_tracker: Fix primitive topology	2020-08-26 22:19:52 -04:00
Lioncash	7b50c48df7	memory_manager: Make use of [[nodiscard]] in the interface	2020-08-26 20:15:03 -04:00
Lioncash	d12d59f62a	memory_manager: Make operator+ const qualified This doesn't modify member state, so it can be marked as const.	2020-08-26 20:11:58 -04:00
bunnei	902bf6d37d	Merge pull request #4574 from lioncash/const-fn memory_manager: Mark IsGranularRange() as a const member function	2020-08-25 11:24:13 -04:00
bunnei	bb752df736	Merge pull request #4542 from ReinUsesLisp/gpu-init-base video_core: Initialize renderer with a GPU	2020-08-24 22:56:11 -04:00
Lioncash	bafef3d1c9	async_shaders: Mark getters as const member functions While we're at it, we can also mark them as nodiscard.	2020-08-24 01:15:50 -04:00
Lioncash	5bce81c3d6	memory_manager: Mark IsGranularRange() as a const member function This doesn't modify internal member state, so it can be marked as const.	2020-08-24 00:37:57 -04:00
Lioncash	bae4e6c2f5	gl_texture_cache: Take std::string by reference in DecorateViewName() LabelGLObject takes a string_view, so we don't need to make copies of the std::string.	2020-08-23 23:36:33 -04:00
Lioncash	f3bb52c0a9	video_core/fence_manager: Remove unnecessary includes Avoids pulling in unnecessary things that can cause rebuilds when they aren't required.	2020-08-23 21:44:50 -04:00
ReinUsesLisp	91df2beee3	video_core/host_shaders: Add CMake integration for string shaders Add the necessary CMake code to copy the contents in a string source shader (GLSL or GLASM) to a header file then consumed by video_core files. This allows editting GLSL in its own files without having to maintain them in source files. For now, only OpenGL presentation shaders are moved, but we can add GLASM presentation shaders and static SPIR-V generation through glslangValidator in the future.	2020-08-23 21:37:20 -03:00
ReinUsesLisp	0eaf7e1daa	gl_shader_util: Use std::string_view instead of star pointer This allows us passing any type of string and hinting the length of the string to the OpenGL driver.	2020-08-23 21:23:54 -03:00
ReinUsesLisp	da53bcee60	video_core: Initialize renderer with a GPU Add an extra step in GPU initialization to be able to initialize render backends with a valid GPU instance.	2020-08-22 01:51:45 -03:00
bunnei	baff9ffcac	Merge pull request #4521 from lioncash/optionalcache gl_shader_disk_cache: Make use of std::nullopt where applicable	2020-08-21 23:56:55 -04:00
bunnei	53fbf8e206	Merge pull request #4523 from lioncash/self-assign macro-interpreter: Resolve -Wself-assign-field warning	2020-08-21 18:25:53 -04:00
ReinUsesLisp	aed6011d7c	vk_state_tracker: Fix primitive topology State track the current primitive topology with a regular comparison instead of using dirty flags. This fixes a bug in dirty flags for this particular state and it also avoids unnecessary state changes as this property is stored in a frequently changed bit field.	2020-08-20 23:07:30 -03:00
ReinUsesLisp	c5a78f4480	vk_device: Use Vulkan 1.0 properly Enable the required capabilities to use Vulkan 1.0 without validation errors and disable those that are not compatible with it.	2020-08-20 16:55:22 -03:00
ReinUsesLisp	29a0ca2391	renderer_vulkan: Create a Vulkan 1.0 instance when 1.1 is not available This commit doesn't make yuzu compatible with Vulkan 1.0 yet, it only creates an 1.0 instance.	2020-08-20 16:55:22 -03:00
bunnei	3ea3de4ecd	Merge pull request #4546 from lioncash/telemetry common/telemetry: Migrate namespace into the Common namespace	2020-08-20 14:29:13 -04:00
bunnei	2d2e235bcf	Merge pull request #4522 from lioncash/vulk-copy vulkan/wrapper: Avoid unnecessary copy in EnumerateInstanceExtensionProperties()	2020-08-18 19:31:35 -04:00
Lioncash	f6bb905182	common/telemetry: Migrate namespace into the Common namespace Migrates the Telemetry namespace into the Common namespace to make the code consistent with the rest of our common code.	2020-08-18 15:08:32 -04:00
bunnei	56c6a5def8	Merge pull request #4535 from lioncash/fileutil common/fileutil: Convert namespace to Common::FS	2020-08-17 22:35:30 -04:00
David	cbaf1bc711	Merge pull request #4443 from ameerj/vk-async-shaders vulkan_renderer: Async shader/graphics pipeline compilation	2020-08-17 15:06:11 +10:00
David	a91acd5365	Merge pull request #4520 from lioncash/pessimize async_shaders: Resolve -Wpessimizing-move warning	2020-08-17 14:36:05 +10:00
ameerj	fde8102a41	Remove unneeded newlines, optional Registry in shader params Addressing feedback from Rodrigo	2020-08-16 16:33:21 -04:00
Ameer J	f49ffdd648	Morph: Update worker allocation comment Co-authored-by: Morph <39850852+Morph1984@users.noreply.github.com>	2020-08-16 12:02:22 -04:00
ameerj	1b829fbd7a	move thread 1/4 count computation into allocate workers method	2020-08-16 12:02:22 -04:00
ameerj	31a76410e8	Address feedback, add shader compile notifier, update setting text	2020-08-16 12:02:22 -04:00
ameerj	c02464f64e	Vk Async Worker directly emplace in cache	2020-08-16 12:02:22 -04:00
ameerj	4539073ce1	Address feedback. Bruteforce delete duplicates	2020-08-16 12:02:22 -04:00
ameerj	6ac97405df	Vk Async pipeline compilation	2020-08-16 12:02:22 -04:00
Lioncash	c4ed791164	common/fileutil: Convert namespace to Common::FS Migrates a remaining common file over to the Common namespace, making it consistent with the rest of common files. This also allows for high-traffic FS related code to alias the filesystem function namespace as namespace FS = Common::FS; for more concise typing.	2020-08-16 06:52:40 -04:00
bunnei	db96034ea4	Merge pull request #4528 from lioncash/discard common: Make use of [[nodiscard]] where applicable	2020-08-16 01:47:54 -04:00
bunnei	404362e1b0	Merge pull request #4519 from lioncash/semi maxwell_3d: Resolve -Wextra-semi warning	2020-08-16 00:55:15 -04:00
Lioncash	1ee060ca0d	common/compression: Roll back std::span changes Seems like all compilers don't support std::span yet.	2020-08-15 17:17:56 -04:00
bunnei	feb243b08d	Merge pull request #4416 from lioncash/span lz4_compression/zstd_compression: Make use of std::span in interfaces	2020-08-15 00:53:11 -04:00
bunnei	2dace90346	Merge pull request #4453 from ReinUsesLisp/block-to-linear textures/decoders: Fix block linear to pitch copies	2020-08-14 19:52:12 -04:00
Lioncash	dcc5562cd5	shader/memory: Amend UNIMPLEMENTED_IF_MSG without a message We need to provide a message for this variant of the macro, so we can simply log out the type being used.	2020-08-14 08:38:37 -04:00
Lioncash	34ec64233a	macro-interpreter: Resolve -Wself-assign-field warning This was assigning the field to itself, which is a no-op. The size doesn't change between its initial assignment and this one, so this is a safe change to make.	2020-08-14 08:26:50 -04:00
Lioncash	167d36ec3c	vulkan/wrapper: Avoid unnecessary copy in EnumerateInstanceExtensionProperties() Given this is implicitly creating a std::optional, we can move the vector into it.	2020-08-14 08:23:49 -04:00
Lioncash	c8135b3c18	gl_shader_disk_cache: Make use of std::nullopt where applicable Allows the compiler to avoid unnecessarily zeroing out the internal buffer of std::optional on some implementations.	2020-08-14 08:20:44 -04:00
Lioncash	6b13d08822	async_shaders: Resolve -Wpessimizing-move warning Prevents pessimization of the move constructor (which thankfully didn't actually happen in practice here, given std::thread isn't copyable).	2020-08-14 08:16:50 -04:00
Lioncash	83d8bf9af9	maxwell_3d: Resolve -Wextra-semi warning Semicolons after a function definition aren't necessary.	2020-08-14 08:13:41 -04:00
bunnei	a9de967fa3	Merge pull request #4514 from Morph1984/worker-alloc gl_shader_cache: Use std::max() for determining num_workers	2020-08-13 17:06:57 -04:00
Lioncash	b724a4d90c	General: Tidy up clang-format warnings part 2	2020-08-13 14:19:08 -04:00
Morph	e0ff98dd34	gl_shader_cache: Use std::max() for determining num_workers Does not allocate more threads than available in the host system for boot-time shader compilation and always allocates at least 1 thread if hardware_concurrency() returns 0.	2020-08-12 09:23:34 -04:00
ReinUsesLisp	f00641459e	textures/decoders: Fix block linear to pitch copies There were two issues with block linear copies. First the swizzling was wrong and this commit reimplements them. The other issue was that these copies are generally used to download render targets from the GPU and yuzu was not downloading them from host GPU memory unless the extreme GPU accuracy setting was selected. This commit enables cached memory reads for all accuracy levels. - Fixes level thumbnails in Super Mario Maker 2.	2020-08-10 20:45:03 -03:00
bunnei	5429ea0e69	Merge pull request #4389 from ogniK5377/redundant-format-type video_core: Remove redundant pixel format type	2020-08-07 09:33:58 -04:00
bunnei	f11628b9b7	Merge pull request #4430 from bunnei/new-gpu-vmm hle: nvdrv: Rewrite of GPU memory management.	2020-08-04 18:44:26 -04:00
bunnei	efd1b57d03	Merge pull request #4445 from Morph1984/async-threads renderer_opengl: Use 1/4 of all threads for async shader compilation	2020-08-04 18:43:42 -04:00
bunnei	0ae267bf77	Merge pull request #4469 from lioncash/missing vk_texture_cache: Silence -Wmissing-field-initializer warnings	2020-08-04 06:59:51 -07:00
Lioncash	06809ad7bc	vulkan: Silence more -Wmissing-field-initializer warnings	2020-08-03 12:28:57 -04:00
Lioncash	b249e4e0ce	yuzu: Resolve C++20 deprecation warnings related to lambda captures C++20 deprecates capturing the this pointer via the '=' capture. Instead, we replace it or extend the capture specification.	2020-08-03 11:54:04 -04:00
David	0c262f8ac2	Merge pull request #4392 from lioncash/guard compatible_formats: Add missing header guard	2020-07-31 01:08:56 +10:00
bunnei	4c0f6f1bc8	Merge pull request #4396 from lioncash/comma surface_params: Replace questionable usages of the comma operator with semicolons	2020-07-29 19:55:44 -04:00
Morph	e8f22730d1	renderer_opengl: Use 1/4 of all threads for async shader compilation	2020-07-28 05:08:27 -04:00
bunnei	6b35317ff3	Merge pull request #4419 from lioncash/initializer vulkan: Resolve -Wmissing-field-initializer warnings	2020-07-27 15:52:03 -07:00
Billy Laws	f490b4545d	video_core/gpu: Correct the size of the puller registers The puller register array is made up of u32s however the `NUM_REGS` value is the size in bytes, so switch it to avoid making the struct unnecessary large. Also fix a small typo in a comment.	2020-07-26 22:26:29 +01:00
bunnei	05def61398	hle: nvdrv: Rewrite of GPU memory management.	2020-07-26 00:49:43 -04:00
Lioncash	80eedff9e1	vulkan: Resolve -Wmissing-field-initializer warnings	2020-07-25 03:50:18 -04:00
Lioncash	c5bdccfecb	zstd_compression: Make use of std::span in interfaces Allows condensing the data and size parameters into a single argument.	2020-07-25 03:11:56 -04:00
bunnei	dc2d31b1b2	Merge pull request #4393 from lioncash/unused5 vk_rasterizer: Remove unused variable in Clear()	2020-07-24 20:33:58 -07:00
bunnei	d488cb843e	Merge pull request #4388 from lioncash/written buffer_cache: Eliminate redundant map lookup in MarkRegionAsWritten()	2020-07-24 11:29:37 -07:00
bunnei	f650cf8a9a	Merge pull request #4391 from lioncash/nrvo video_core: Allow copy elision to take place where applicable	2020-07-24 06:33:09 -07:00
bunnei	1d7de0a8ee	Merge pull request #4394 from lioncash/unused6 video_core: Remove unused variables	2020-07-23 19:54:59 -07:00
Rodrigo Locatti	7278c59d70	Merge pull request #4359 from ReinUsesLisp/clamp-shared renderer_{opengl,vulkan}: Clamp shared memory to host's limit	2020-07-21 04:51:05 -03:00
Rodrigo Locatti	721e6015a8	Merge pull request #4360 from ReinUsesLisp/glasm-bar gl_arb_decompiler: Execute BAR even when inside control flow	2020-07-21 04:50:55 -03:00
Rodrigo Locatti	9ea9a60e17	Merge pull request #4361 from ReinUsesLisp/lane-id decode/other: Implement S2R.LaneId	2020-07-21 04:50:45 -03:00
Lioncash	82b7e5c8ee	surface_params: Make use of designated initializers where applicable Provides a convenient way to avoid unnecessary zero initializing.	2020-07-21 02:27:22 -04:00
Lioncash	bd9545a3a8	surface_params: Remove redundant assignment This is a redundant assignment that can be removed.	2020-07-21 02:26:49 -04:00
Lioncash	c705a1db96	surface_params: Replace questionable usages of the comma operator with semicolons These are bugs waiting to happen.	2020-07-21 02:26:48 -04:00
Lioncash	e17fb5ee97	video_core: Remove unused variables Silences several compiler warnings about unused variables.	2020-07-21 00:57:25 -04:00
Lioncash	4b369126c4	vk_rasterizer: Remove unused variable in Clear() The relevant values are already assigned further down in the lambda, so this can be removed entirely.	2020-07-21 00:49:10 -04:00
Lioncash	059305a6bf	compatible_formats: Add missing header guard Prevents potential inclusion issues from occurring.	2020-07-21 00:42:19 -04:00
Lioncash	6adc824d9d	video_core: Allow copy elision to take place where applicable Removes const from some variables that are returned from functions, as this allows the move assignment/constructors to execute for them.	2020-07-21 00:36:13 -04:00
bunnei	3d13d7f48f	Merge pull request #4324 from ReinUsesLisp/formats video_core: Fix, add and rename pixel formats	2020-07-21 00:13:04 -04:00
David Marcec	dd4a02d15c	video_core: Remove redundant pixel format type We already get the format type before converting shadow formats and during shadow formats.	2020-07-21 12:44:32 +10:00
Lioncash	26c6c71837	buffer_cache: Eliminate redundant map lookup in MarkRegionAsWritten() We can make use of emplace()'s return value to determine whether or not we need to perform an increment. emplace() performs no insertion if an element already exist, so this can eliminate a find() call.	2020-07-20 17:48:00 -04:00
ReinUsesLisp	a8a2526128	gl_arb_decompiler: Use NV_shader_buffer_{load,store} on assembly shaders NV_shader_buffer_{load,store} is a 2010 extension that allows GL applications to use what in Vulkan is known as physical pointers, this is basically C pointers. On GLASM these is exposed through the LOAD/STORE/ATOM instructions. Up until now, assembly shaders were using NV_shader_storage_buffer_object. These work fine, but have a (probably unintended) limitation that forces us to have the limit of a single stage for all shader stages. In contrast, with NV_shader_buffer_{load,store} we can pass GPU addresses to the shader through local parameters (GLASM equivalent uniform constants, or push constants on Vulkan). Local parameters have the advantage of being per stage, allowing us to generate code without worrying about binding overlaps.	2020-07-18 01:59:57 -03:00
bunnei	90cbcaa44a	Merge pull request #4273 from ogniK5377/async-shaders-prod video_core: Add asynchronous shader decompilation and compilation	2020-07-18 00:48:27 -04:00
David Marcec	967307d3be	Fix style issues	2020-07-18 14:24:32 +10:00
bunnei	821d295f24	Merge pull request #4364 from lioncash/desig5 vulkan: Make use of designated initializers where applicable	2020-07-18 00:12:43 -04:00
ReinUsesLisp	81c8f92f2e	vk_device: Fix build error on old MSVC versions Designated initializers on old MSVC versions fail to build when they take the address of a constant.	2020-07-17 20:27:53 -03:00
bunnei	19c6bf72db	Merge pull request #4322 from ReinUsesLisp/fix-dynstate vk_state_tracker: Fix dirty flags for stencil_enable on VK_EXT_extended_dynamic_state	2020-07-17 09:50:45 -04:00
LC	47956a3bbc	Merge pull request #4369 from lioncash/hle-macro macro_hle: Remove unnecessary std::make_pair calls	2020-07-17 05:20:41 -04:00
LC	9d3cbf6a90	Merge pull request #4340 from lioncash/remove shader_cache: Make use of std::erase_if	2020-07-17 05:19:20 -04:00
David Marcec	85b591f6f0	Remove duplicate config	2020-07-17 14:26:18 +10:00
David Marcec	f48187449e	Use conditional var	2020-07-17 14:26:17 +10:00
David Marcec	2ba195aa0d	Drop max workers from 8->2 for testing	2020-07-17 14:26:15 +10:00
David Marcec	85d7a8f466	Rebase for per game settings	2020-07-17 14:26:14 +10:00
David Marcec	468bd9c1b0	async shaders	2020-07-17 14:24:57 +10:00
Lioncash	c0650cd82c	macro_hle: Remove unnecessary static keywords These functions are already in an anonymous namespace which makes the functions internally linked.	2020-07-16 23:17:17 -04:00
David	9cca0c2f83	Merge pull request #4368 from lioncash/macro macro: Resolve missing parameter in doxygen comment	2020-07-17 13:13:22 +10:00
David	3ce4edba64	Merge pull request #4370 from lioncash/simplify macro_hle: Simplify shift expression in HLE_771BB18C62444DA0()	2020-07-17 13:13:05 +10:00
Lioncash	be6b7591d9	macro_hle: Simplify shift expression in HLE_771BB18C62444DA0() Given the expression involves a 32-bit value, this simplifies down to just: 0x3ffffff. This is likely a remnant from testing that was never cleaned up. Resolves a -Wshift-overflow warning.	2020-07-16 22:16:11 -04:00
Lioncash	cc935d997b	macro_hle: Remove unnecessary std::make_pair calls The purpose of make_pair is generally to deduce the types within the pair without explicitly specifying the types, so these usages were generally unnecessary, particularly when the type is enforced by the array declaration.	2020-07-16 21:59:25 -04:00
Lioncash	502dbfb9eb	macro: Resolve missing parameter in doxygen comment Resolves a -Wdocumentation warning.	2020-07-16 21:54:42 -04:00
Lioncash	7785123b1c	wrapper: Make use of designated initializers where applicable	2020-07-16 20:01:01 -04:00
Lioncash	01da386617	vk_texture_cache: Make use of designated initializers where applicable	2020-07-16 19:52:38 -04:00
Lioncash	169759e069	vk_texture_cache: Amend mismatched access masks and indices in UploadBuffer Discovered while converting relevant parts of the codebase over to designated initializers.	2020-07-16 19:45:46 -04:00
Lioncash	08d36afd40	vk_swapchain: Make use of designated initializers where applicable	2020-07-16 19:27:02 -04:00
Lioncash	3c060503bc	vk_stream_buffer: Make use of designated initializers where applicable	2020-07-16 19:22:11 -04:00
Lioncash	70147e913f	vk_staging_buffer_pool: Make use of designated initializers where applicable	2020-07-16 19:22:03 -04:00
Lioncash	2025f847bb	vk_shader_util: Make use of designated initializers where applicable	2020-07-16 19:17:41 -04:00
Lioncash	97e7663004	vk_scheduler: Make use of designated initializers where applicable	2020-07-16 19:11:43 -04:00
Lioncash	fd7af52ec3	vk_sampler_cache: Make use of designated initializers where applicable	2020-07-16 19:06:40 -04:00
Lioncash	772b6e4d28	vk_resource_manager: Make use of designated initializers where applicable	2020-07-16 19:02:35 -04:00
Lioncash	8ebd6a21c5	vk_renderpass_cache: Make use of designated initializers where applicable	2020-07-16 18:57:23 -04:00
Lioncash	01f297f2e0	vk_rasterizer: Make use of designated initializers where applicable	2020-07-16 18:49:42 -04:00
Lioncash	c07b0ffe47	vk_query_cache: Make use of designated initializers where applicable	2020-07-16 18:34:04 -04:00
Lioncash	d43e923990	vk_pipeline_cache: Make use of designated initializers where applicable	2020-07-16 18:32:29 -04:00
Lioncash	7d5f93832c	vk_memory_manager: Make use of designated initializers where applicable	2020-07-16 18:26:30 -04:00
Lioncash	75c00c3cb0	vk_image: Make use of designated initializers where applicable	2020-07-16 18:24:26 -04:00
Lioncash	6d165481ad	vk_descriptor_pool: Make use of designated initializers where applicable	2020-07-16 18:19:45 -04:00
Lioncash	fb563e75e9	vk_graphics_pipeline: Resolve narrowing warnings For whatever reason, VK_TRUE and VK_FALSE aren't defined as having a VkBool32 type, so we need to cast to it explicitly.	2020-07-16 18:13:49 -04:00
Lioncash	5330ca396d	vk_compute_pipeline: Make use of designated initializers where applicable	2020-07-16 17:32:12 -04:00
Lioncash	757ddd8158	vk_compute_pass: Make use of designated initializers where applicable Note: Some barriers can't be converted over yet, as they ICE MSVC.	2020-07-16 17:23:56 -04:00
Lioncash	a66a0a6a53	vk_buffer_cache: Make use of designated initializers where applicable Note: An array within CopyFrom() cannot be converted over yet, as it ICEs MSVC when converted over.	2020-07-16 16:59:39 -04:00
Rodrigo Locatti	be68ee88c2	Merge pull request #4333 from lioncash/desig3 vk_graphics_pipeline: Make use of designated initializers where applicable	2020-07-16 17:41:45 -03:00
Rodrigo Locatti	b6d73ec9c2	Merge pull request #4332 from lioncash/vkdev vk_device: Make use of designated initializers where applicable	2020-07-16 17:41:20 -03:00
ReinUsesLisp	210cc0204d	decode/other: Implement S2R.LaneId This maps to host's thread id. - Fixes graphical issues on Paper Mario.	2020-07-16 16:09:39 -03:00
ReinUsesLisp	88e57b13e0	gl_arb_decompiler: Execute BAR even when inside control flow Unlike GLSL, GLASM allows us to call BAR inside control flow. - Fixes graphical artifacts in Paper Mario.	2020-07-16 16:05:52 -03:00
ReinUsesLisp	a5a72cbd20	renderer_{opengl,vulkan}: Clamp shared memory to host's limit This stops shaders from failing to build when the exceed host's shared memory size limit. An error is logged.	2020-07-16 16:02:46 -03:00
bunnei	98b36625fa	Merge pull request #4321 from lioncash/desig vk_blit_screen: Make use of designated initializers where applicable	2020-07-16 14:55:36 -04:00
Lioncash	969100d41a	shader_cache: Make use of std::erase_if Now that we use C++20, we can also make use of std::erase_if instead of needing to do the erase-remove idiom.	2020-07-14 15:49:15 -04:00
bunnei	666b37ad56	Merge pull request #4242 from ReinUsesLisp/maxwell-dma maxwell_dma: Match official doc and support pitch->voxel copies	2020-07-14 14:04:16 -04:00
Lioncash	0f8b977663	vk_device: Make use of designated initializers where applicable Avoids redundant repetitions of variable names, and allows assignment all in one statement.	2020-07-13 22:24:01 -04:00
Lioncash	0475a167f8	vk_graphics_pipeline: Make use of designated initializers where applicable Avoids redundant variable name repetitions.	2020-07-13 21:07:56 -04:00
ReinUsesLisp	fbc232426d	video_core: Rearrange pixel format names Normalizes pixel format names to match Vulkan names. Previous to this commit pixel formats had no convention, leading to confusion and potential bugs.	2020-07-13 01:44:23 -03:00
ReinUsesLisp	eda37ff26b	video_core: Fix DXT4 and RGB565	2020-07-13 01:01:09 -03:00
ReinUsesLisp	a8dab2ffb3	video_core/format_lookup_table: Add formats with existing PixelFormat	2020-07-13 01:01:09 -03:00
ReinUsesLisp	480850ffe7	video_core: Fix B5G6R5_UNORM render target format	2020-07-13 01:01:09 -03:00
ReinUsesLisp	990b14f181	video_core: Fix B5G6R5U	2020-07-13 01:01:09 -03:00
ReinUsesLisp	1d20aac795	video_core: Implement RGBA32_SINT render target	2020-07-13 01:01:09 -03:00

... 5 6 7 8 9 ...

5219 Commits