Rodrigo Locatti 
							
						 
					 
					
						
						
							
						
						8ed0d92e32 
					 
					
						
						
							
							Revert "common/bit_field: Silence sign-conversion warnings"  
						
						
						
						
					 
					
						2019-11-16 03:29:37 -03:00 
						 
				 
			
				
					
						
							
							
								Rodrigo Locatti 
							
						 
					 
					
						
						
							
						
						3026aec9bd 
					 
					
						
						
							
							Merge pull request  #3106  from lioncash/bitfield  
						
						... 
						
						
						
						common/bit_field: Silence sign-conversion warnings 
						
						
					 
					
						2019-11-15 18:49:20 -03:00 
						 
				 
			
				
					
						
							
							
								bunnei 
							
						 
					 
					
						
						
							
						
						a8295d2c53 
					 
					
						
						
							
							Merge pull request  #3047  from ReinUsesLisp/clip-control  
						
						... 
						
						
						
						gl_rasterizer: Emulate viewport flipping with ARB_clip_control 
						
						
					 
					
						2019-11-15 12:09:19 -05:00 
						 
				 
			
				
					
						
							
							
								bunnei 
							
						 
					 
					
						
						
							
						
						3e0e4f146b 
					 
					
						
						
							
							Merge pull request  #3091  from lioncash/core-conversion  
						
						... 
						
						
						
						core: Make most implicit type conversion warnings errors on MSVC 
						
						
					 
					
						2019-11-15 12:08:50 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						14581e4a59 
					 
					
						
						
							
							common/bit_field: Silence sign-conversion warnings  
						
						... 
						
						
						
						We can just use numeric_limits instead of relying on wraparound behavior
here. 
						
						
					 
					
						2019-11-15 07:09:30 -05:00 
						 
				 
			
				
					
						
							
							
								Rodrigo Locatti 
							
						 
					 
					
						
						
							
						
						bb31df62bb 
					 
					
						
						
							
							Merge pull request  #3113  from lioncash/semi  
						
						... 
						
						
						
						common_funcs: Remove semicolons from INSERT_PADDING_* macros 
						
						
					 
					
						2019-11-14 20:29:51 -03:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						f2e34efcbb 
					 
					
						
						
							
							common_funcs: Remove semicolons from INSERT_PADDING_* macros  
						
						... 
						
						
						
						Makes code that uses the macros consistent by requiring the lines to be
terminated with a semicolon. 
						
						
					 
					
						2019-11-14 17:05:27 -05:00 
						 
				 
			
				
					
						
							
							
								greggameplayer 
							
						 
					 
					
						
						
							
						
						c6bc13d0aa 
					 
					
						
						
							
							correct the implementation of RGBA16UI  
						
						
						
						
					 
					
						2019-11-14 21:37:39 +01:00 
						 
				 
			
				
					
						
							
							
								bunnei 
							
						 
					 
					
						
						
							
						
						885d88825e 
					 
					
						
						
							
							Merge pull request  #3089  from SciresM/play_statistics  
						
						... 
						
						
						
						Implement stub for IApplicationFunctions::QueryApplicationPlayStatisticsByUid 
						
						
					 
					
						2019-11-14 13:54:29 -05:00 
						 
				 
			
				
					
						
							
							
								bunnei 
							
						 
					 
					
						
						
							
						
						360b0d1b30 
					 
					
						
						
							
							Merge pull request  #3093  from lioncash/mbedtls  
						
						... 
						
						
						
						core: Migrate off deprecated mbedtls functions 
						
						
					 
					
						2019-11-14 13:47:23 -05:00 
						 
				 
			
				
					
						
							
							
								bunnei 
							
						 
					 
					
						
						
							
						
						02880a8195 
					 
					
						
						
							
							Merge pull request  #3092  from lioncash/util  
						
						... 
						
						
						
						key_manager: Make use of IOFile in WriteKeyToFile() 
						
						
					 
					
						2019-11-14 13:46:55 -05:00 
						 
				 
			
				
					
						
							
							
								Fernando Sahmkow 
							
						 
					 
					
						
						
							
						
						b6f6733131 
					 
					
						
						
							
							Merge pull request  #3081  from ReinUsesLisp/fswzadd-shuffles  
						
						... 
						
						
						
						shader: Implement FSWZADD and reimplement SHFL 
						
						
					 
					
						2019-11-14 10:27:27 -04:00 
						 
				 
			
				
					
						
							
							
								Rodrigo Locatti 
							
						 
					 
					
						
						
							
						
						7f424d0f60 
					 
					
						
						
							
							Merge pull request  #3107  from lioncash/hashable  
						
						... 
						
						
						
						common/hash: Remove unused HashableStruct 
						
						
					 
					
						2019-11-13 17:30:30 -03:00 
						 
				 
			
				
					
						
							
							
								Rodrigo Locatti 
							
						 
					 
					
						
						
							
						
						ebb30cbefb 
					 
					
						
						
							
							Merge pull request  #3104  from lioncash/xts  
						
						... 
						
						
						
						xts_archive: Remove redundant std::string constructor 
						
						
					 
					
						2019-11-13 17:00:02 -03:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						c5c89a4d5c 
					 
					
						
						
							
							common/hash: Remove unused HashableStruct  
						
						... 
						
						
						
						This is unused, so it can be removed. There's better ways of ensuring
zeroed out padding bits, like using zero-initialization, anyhow. 
						
						
					 
					
						2019-11-13 14:58:43 -05:00 
						 
				 
			
				
					
						
							
							
								Rodrigo Locatti 
							
						 
					 
					
						
						
							
						
						cc9e682021 
					 
					
						
						
							
							Merge pull request  #3103  from lioncash/cfunc  
						
						... 
						
						
						
						common_funcs: silence sign-conversion warnings in MakeMagic() 
						
						
					 
					
						2019-11-13 16:26:34 -03:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						03b73aa575 
					 
					
						
						
							
							xts_archive: Remove redundant std::string constructor  
						
						... 
						
						
						
						We can just call the .data() member of path instead of constructing a
completely new string. 
						
						
					 
					
						2019-11-13 10:02:10 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						61f6eaad45 
					 
					
						
						
							
							common_funcs: silence sign-conversion warnings in MakeMagic()  
						
						... 
						
						
						
						We can trivially resolve these by casting the characters to unsigned
values and then shifting the bits. 
						
						
					 
					
						2019-11-13 06:53:19 -05:00 
						 
				 
			
				
					
						
							
							
								Rodrigo Locatti 
							
						 
					 
					
						
						
							
						
						cf770a68a5 
					 
					
						
						
							
							Merge pull request  #3084  from ReinUsesLisp/cast-warnings  
						
						... 
						
						
						
						video_core: Treat implicit conversions as errors 
						
						
					 
					
						2019-11-13 02:16:22 -03:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						64cbebc58f 
					 
					
						
						
							
							key_manager: Make use of IOFile in WriteKeyToFile()  
						
						... 
						
						
						
						This properly handles unicode-based paths on Windows, while opening a
raw stream doesn't out-of-the-box.
Prevents file creation from potentially failing on Windows PCs that make
use of unicode characters in their save paths (e.g. writing to a user's
AppData folder, where the user has a name with non-ASCII characters). 
						
						
					 
					
						2019-11-12 08:52:18 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						e0c46e6879 
					 
					
						
						
							
							core: Migrate off deprecated mbedtls functions  
						
						... 
						
						
						
						These functions are marked for deprecation and it's recommended that the
*_ret variants be used instead. 
						
						
					 
					
						2019-11-12 08:45:56 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						47a6bb2d5b 
					 
					
						
						
							
							externals: Update httplib  
						
						... 
						
						
						
						Since the introduction of this library, numerous improvements have been
made. Notably, many of the warnings we would get by simply including the
library header have now been fixed. This makes it much easier to make
conversion warning an error. 
						
						
					 
					
						2019-11-12 08:31:27 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						f11b87ebf1 
					 
					
						
						
							
							service: Resolve sign conversion errors  
						
						... 
						
						
						
						These are fairly trivial to resolve and most of the changes entail
using RESULT_UNKNOWN over ResultCode(-1). 
						
						
					 
					
						2019-11-12 07:55:39 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						75dec14f21 
					 
					
						
						
							
							perf_stats: Resolve implicit int to double conversion error  
						
						... 
						
						
						
						We simply need to turn the literal argument to std::accumulate into a
double, rather than an int. 
						
						
					 
					
						2019-11-12 07:55:39 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						23878bf360 
					 
					
						
						
							
							loader; Resolve sign conversion/truncation errors  
						
						
						
						
					 
					
						2019-11-12 07:55:39 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						86a1eb7789 
					 
					
						
						
							
							gdbstub: Resolve sign conversion errors  
						
						
						
						
					 
					
						2019-11-12 07:55:39 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						12dc918937 
					 
					
						
						
							
							kernel: Resolve sign conversion warnings  
						
						... 
						
						
						
						Uncovered a bug within Thread's SetCoreAndAffinityMask() where an
unsigned variable (ideal_core) was being compared against "< 0", which
would always be a false condition.
We can also get rid of an unused function (GetNextProcessorId) which contained a sign
mismatch warning. 
						
						
					 
					
						2019-11-12 07:55:39 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						86c397dd6e 
					 
					
						
						
							
							file_sys: Resolve sign conversion warnings  
						
						... 
						
						
						
						Resolves a few trivial sign conversion/mismatch errors. 
						
						
					 
					
						2019-11-12 07:55:39 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						ef060ed40c 
					 
					
						
						
							
							result: Add default error code for the ResultCode(-1) case  
						
						... 
						
						
						
						Will be used to reduce the overall duplication of the same magic value
all over the codebase in following changes. 
						
						
					 
					
						2019-11-12 07:55:38 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						581d2e36e5 
					 
					
						
						
							
							crypto: Resolve sign-conversion warnings  
						
						
						
						
					 
					
						2019-11-12 07:55:22 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						27ab99490e 
					 
					
						
						
							
							result: Resolve sign-coversion warnings  
						
						... 
						
						
						
						The constructor was implicitly using signed->unsigned conversions to
produce 0xFFFFFFFF. We can just specify this explicitly with UINT32_MAX. 
						
						
					 
					
						2019-11-12 07:06:48 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						19a0abc19b 
					 
					
						
						
							
							arm_unicorn: Resolve sign conversion warnings  
						
						... 
						
						
						
						While we're at it, this also resolves a type truncation warning as well,
given the code was truncating from a 64-bit value to a 32-bit one. 
						
						
					 
					
						2019-11-12 07:06:48 -05:00 
						 
				 
			
				
					
						
							
							
								Lioncash 
							
						 
					 
					
						
						
							
						
						96d677bef0 
					 
					
						
						
							
							CMakeLists: Make most implicit type conversion warnings errors on MSVC  
						
						... 
						
						
						
						Quite frequently there have been cases where code has been merged into
the core that produces warning. In order to prevent this from occurring,
we can make the compiler flag these cases and allow our CI to flag down
any code that would generate these warnings.
This is beneficial given silent conversions from signed/unsigned can
result in logic bugs. This forces one writing changes to be explicit
about when signedness conversions are desirable, rather than leaving it
up to readers' interpretation.
Currently the codebase isn't in a state where it will build successfully
with this change applied, but this will be addressed in subsequent
follow-up changes. This set of changes will focus on making it build
properly with these changes for MSVC as a starting point for basic
coverage. 
						
						
					 
					
						2019-11-12 07:06:25 -05:00 
						 
				 
			
				
					
						
							
							
								Rodrigo Locatti 
							
						 
					 
					
						
						
							
						
						fb9418798d 
					 
					
						
						
							
							video_core: Enable sign conversion warnings  
						
						... 
						
						
						
						Enable sign conversion warnings but don't treat them as errors. 
						
						
					 
					
						2019-11-11 18:00:37 -03:00 
						 
				 
			
				
					
						
							
							
								Michael Scire 
							
						 
					 
					
						
						
							
						
						b0b0786493 
					 
					
						
						
							
							Implement stub for QueryApplicationPlayStatisticsByUid  
						
						
						
						
					 
					
						2019-11-11 07:32:47 -08:00 
						 
				 
			
				
					
						
							
							
								bunnei 
							
						 
					 
					
						
						
							
						
						8714d40a77 
					 
					
						
						
							
							Merge pull request  #3085  from bunnei/web-token-b64  
						
						... 
						
						
						
						yuzu: configure_web: Use Base64 encoded token 
						
						
					 
					
						2019-11-09 14:50:31 -05:00 
						 
				 
			
				
					
						
							
							
								bunnei 
							
						 
					 
					
						
						
							
						
						8dc9f35baf 
					 
					
						
						
							
							web-service: Port citra's updated web_backend code.  
						
						
						
						
					 
					
						2019-11-09 14:00:44 -05:00 
						 
				 
			
				
					
						
							
							
								bunnei 
							
						 
					 
					
						
						
							
						
						883eb1a1a1 
					 
					
						
						
							
							yuzu: configure_web: Use Base64 encoded token for simplifying user experience.  
						
						
						
						
					 
					
						2019-11-09 14:00:44 -05:00 
						 
				 
			
				
					
						
							
							
								bunnei 
							
						 
					 
					
						
						
							
						
						0fc596de6e 
					 
					
						
						
							
							Merge pull request  #3082  from ReinUsesLisp/fix-lockers  
						
						... 
						
						
						
						gl_shader_cache: Fix locker constructors 
						
						
					 
					
						2019-11-09 13:58:36 -05:00 
						 
				 
			
				
					
						
							
							
								ReinUsesLisp 
							
						 
					 
					
						
						
							
						
						18c1cb68fd 
					 
					
						
						
							
							video_core: Treat implicit conversions as errors  
						
						
						
						
					 
					
						2019-11-08 22:49:39 +00:00 
						 
				 
			
				
					
						
							
							
								ReinUsesLisp 
							
						 
					 
					
						
						
							
						
						096f339a2a 
					 
					
						
						
							
							video_core: Silence implicit conversion warnings  
						
						
						
						
					 
					
						2019-11-08 22:48:50 +00:00 
						 
				 
			
				
					
						
							
							
								bunnei 
							
						 
					 
					
						
						
							
						
						a056d8de16 
					 
					
						
						
							
							Merge pull request  #3080  from FernandoS27/glsl-fix  
						
						... 
						
						
						
						GLSLDecompiler: Correct Texture Gather Offset. 
						
						
					 
					
						2019-11-08 15:56:29 -05:00 
						 
				 
			
				
					
						
							
							
								ReinUsesLisp 
							
						 
					 
					
						
						
							
						
						bfa973a62b 
					 
					
						
						
							
							gl_shader_cache: Fix locker constructors  
						
						... 
						
						
						
						Properly pass engine when a shader is being constructed from memory. 
						
						
					 
					
						2019-11-07 20:43:31 -03:00 
						 
				 
			
				
					
						
							
							
								ReinUsesLisp 
							
						 
					 
					
						
						
							
						
						3ab0514698 
					 
					
						
						
							
							gl_shader_cache: Enable extensions only when available  
						
						... 
						
						
						
						Silence GLSL compilation warnings. 
						
						
					 
					
						2019-11-07 20:08:42 -03:00 
						 
				 
			
				
					
						
							
							
								ReinUsesLisp 
							
						 
					 
					
						
						
							
						
						cd66395944 
					 
					
						
						
							
							gl_shader_decompiler: Add safe fallbacks when ARB_shader_ballot is not available  
						
						
						
						
					 
					
						2019-11-07 20:08:42 -03:00 
						 
				 
			
				
					
						
							
							
								ReinUsesLisp 
							
						 
					 
					
						
						
							
						
						56e237d1f9 
					 
					
						
						
							
							shader_ir/warp: Implement FSWZADD  
						
						
						
						
					 
					
						2019-11-07 20:08:41 -03:00 
						 
				 
			
				
					
						
							
							
								ReinUsesLisp 
							
						 
					 
					
						
						
							
						
						08b2b1080a 
					 
					
						
						
							
							gl_shader_decompiler: Reimplement shuffles with platform agnostic intrinsics  
						
						
						
						
					 
					
						2019-11-07 20:08:41 -03:00 
						 
				 
			
				
					
						
							
							
								Fernando Sahmkow 
							
						 
					 
					
						
						
							
						
						3d7c284e0f 
					 
					
						
						
							
							GLSLDecompiler: Correct Texture Gather Offset.  
						
						... 
						
						
						
						This commit corrects the argument ordering in textureGatherOffset. 
						
						
					 
					
						2019-11-07 11:43:56 -04:00 
						 
				 
			
				
					
						
							
							
								bunnei 
							
						 
					 
					
						
						
							
						
						b6ae48966d 
					 
					
						
						
							
							Merge pull request  #3032  from ReinUsesLisp/simplify-control-flow-brx  
						
						... 
						
						
						
						shader/control_flow: Abstract repeated code chunks in BRX tracking 
						
						
					 
					
						2019-11-07 01:30:01 -05:00 
						 
				 
			
				
					
						
							
							
								Morph 
							
						 
					 
					
						
						
							
						
						0e8a3bf3e5 
					 
					
						
						
							
							buffer_cache: Add missing includes ( #3079 )  
						
						... 
						
						
						
						`boost::make_iterator_range` is available when `boost/range/iterator_range.hpp` is included.
Also include `boost/icl/interval_map.hpp` and `boost/icl/interval_set.hpp`. 
						
						
					 
					
						2019-11-07 06:25:53 +00:00