From e107870bc831e251478e41dcd4d517aa5febd05d Mon Sep 17 00:00:00 2001
From: Lioncash <mathew1800@gmail.com>
Date: Wed, 23 Sep 2020 13:20:10 -0400
Subject: [PATCH 1/2] install_dialog: Remove unused function prototype
This function doesn't have an implementation, so it can be removed to
prevent others from unintentionally using it.
---
src/yuzu/install_dialog.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/yuzu/install_dialog.h b/src/yuzu/install_dialog.h
index e4aba1b06f..4293b37228 100644
--- a/src/yuzu/install_dialog.h
+++ b/src/yuzu/install_dialog.h
@@ -21,7 +21,6 @@ public:
~InstallDialog() override;
QStringList GetFiles() const;
- bool ShouldOverwriteFiles() const;
int GetMinimumWidth() const;
private:
From aa35e51fcd4527220ce6d793cf6736bbac25aea5 Mon Sep 17 00:00:00 2001
From: Lioncash <mathew1800@gmail.com>
Date: Wed, 23 Sep 2020 13:22:01 -0400
Subject: [PATCH 2/2] install_dialog: Make use of [[nodiscard]] where
applicable
Allows the compiler to warn against cases where the return value isn't
used (which would be a bug).
---
src/yuzu/install_dialog.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/yuzu/install_dialog.h b/src/yuzu/install_dialog.h
index 4293b37228..68e03fe4e0 100644
--- a/src/yuzu/install_dialog.h
+++ b/src/yuzu/install_dialog.h
@@ -20,8 +20,8 @@ public:
explicit InstallDialog(QWidget* parent, const QStringList& files);
~InstallDialog() override;
- QStringList GetFiles() const;
- int GetMinimumWidth() const;
+ [[nodiscard]] QStringList GetFiles() const;
+ [[nodiscard]] int GetMinimumWidth() const;
private:
QListWidget* file_list;