mirror of
https://github.com/citra-emu/citra.git
synced 2024-12-02 22:30:05 +00:00
623b0621ab
* common/thread: Remove unused functions Many of these functions are carried over from Dolphin (where they aren't used anymore). Given these have no use (and we really shouldn't be screwing around with OS-specific thread scheduler handling from the emulator, these can be removed. The function for setting the thread name is left, however, since it can have debugging utility usages. * input_common/sdl: Use a type alias to shorten declaration of GetPollers Just makes the definitions a little bit more tidy. * input_common/sdl: Correct return values within implementations of GetPollers() In both cases, we weren't actually returning anything, which is undefined behavior. * yuzu/debugger/graphics_surface: Fill in missing surface format listings Fills in the missing surface types that were marked as unknown. The order corresponds with the TextureFormat enum within video_core/texture.h. We also don't need to all of these strings as translatable (only the first string, as it's an English word). * yuzu/debugger/graphics_surface: Clean up connection overload deduction We can utilize qOverload with the signal connections to make the function deducing a little less ugly. * yuzu/debugger/graphics_surface: Tidy up SaveSurface - Use QStringLiteral where applicable. - Use const where applicable - Remove unnecessary precondition check (we already assert the pixbuf being non null) * yuzu/debugger/graphics_surface: Display error messages for file I/O errors * core: Add missing override specifiers where applicable Applies the override specifier where applicable. In the case of destructors that are defaulted in their definition, they can simply be removed. This also removes the unnecessary inclusions being done in audin_u and audrec_u, given their close proximity. * kernel/thread: Make parameter of GetWaitObjectIndex() const qualified The pointed to member is never actually modified, so it can be made const. * kernel/thread: Avoid sign conversion within GetCommandBufferAddress() Previously this was performing a u64 + int sign conversion. When dealing with addresses, we should generally be keeping the arithmetic in the same signedness type. This also gets rid of the static lifetime of the constant, as there's no need to make a trivial type like this potentially live for the entire duration of the program. * kernel/codeset: Make CodeSet's memory data member a regular std::vector The use of a shared_ptr is an implementation detail of the VMManager itself when mapping memory. Because of that, we shouldn't require all users of the CodeSet to have to allocate the shared_ptr ahead of time. It's intended that CodeSet simply pass in the required direct data, and that the memory manager takes care of it from that point on. This means we just do the shared pointer allocation in a single place, when loading modules, as opposed to in each loader. * kernel/wait_object: Make ShouldWait() take thread members by pointer-to-const Given this is intended as a querying function, it doesn't make sense to allow the implementer to modify the state of the given thread.
97 lines
2.4 KiB
C++
97 lines
2.4 KiB
C++
// Copyright 2013 Dolphin Emulator Project / 2014 Citra Emulator Project
|
|
// Licensed under GPLv2 or any later version
|
|
// Refer to the license.txt file included.
|
|
|
|
#pragma once
|
|
|
|
#include <chrono>
|
|
#include <condition_variable>
|
|
#include <cstddef>
|
|
#include <mutex>
|
|
#include <thread>
|
|
|
|
namespace Common {
|
|
|
|
class Event {
|
|
public:
|
|
void Set() {
|
|
std::lock_guard lk{mutex};
|
|
if (!is_set) {
|
|
is_set = true;
|
|
condvar.notify_one();
|
|
}
|
|
}
|
|
|
|
void Wait() {
|
|
std::unique_lock lk{mutex};
|
|
condvar.wait(lk, [&] { return is_set; });
|
|
is_set = false;
|
|
}
|
|
|
|
template <class Duration>
|
|
bool WaitFor(const std::chrono::duration<Duration>& time) {
|
|
std::unique_lock lk(mutex);
|
|
if (!condvar.wait_for(lk, time, [this] { return is_set; }))
|
|
return false;
|
|
is_set = false;
|
|
return true;
|
|
}
|
|
|
|
template <class Clock, class Duration>
|
|
bool WaitUntil(const std::chrono::time_point<Clock, Duration>& time) {
|
|
std::unique_lock lk{mutex};
|
|
if (!condvar.wait_until(lk, time, [this] { return is_set; }))
|
|
return false;
|
|
is_set = false;
|
|
return true;
|
|
}
|
|
|
|
void Reset() {
|
|
std::unique_lock lk{mutex};
|
|
// no other action required, since wait loops on the predicate and any lingering signal will
|
|
// get cleared on the first iteration
|
|
is_set = false;
|
|
}
|
|
|
|
private:
|
|
bool is_set = false;
|
|
std::condition_variable condvar;
|
|
std::mutex mutex;
|
|
};
|
|
|
|
class Barrier {
|
|
public:
|
|
explicit Barrier(std::size_t count_) : count(count_) {}
|
|
|
|
/// Blocks until all "count" threads have called Sync()
|
|
void Sync() {
|
|
std::unique_lock lk{mutex};
|
|
const std::size_t current_generation = generation;
|
|
|
|
if (++waiting == count) {
|
|
generation++;
|
|
waiting = 0;
|
|
condvar.notify_all();
|
|
} else {
|
|
condvar.wait(lk,
|
|
[this, current_generation] { return current_generation != generation; });
|
|
}
|
|
}
|
|
|
|
std::size_t Generation() const {
|
|
std::unique_lock lk(mutex);
|
|
return generation;
|
|
}
|
|
|
|
private:
|
|
std::condition_variable condvar;
|
|
mutable std::mutex mutex;
|
|
std::size_t count;
|
|
std::size_t waiting = 0;
|
|
std::size_t generation = 0; // Incremented once each time the barrier is used
|
|
};
|
|
|
|
void SetCurrentThreadName(const char* name);
|
|
|
|
} // namespace Common
|