OpenPunk/citra
1
0
Fork 0
mirror of https://github.com/citra-emu/citra.git synced 2024-11-15 01:50:06 +00:00
Code Issues Projects Releases Wiki Activity

disassembler: Get rid of a const_cast

Browse Source
This commit is contained in:
Lioncash 2015-03-30 15:37:34 -04:00
parent c4767f3bb2
commit e05d6220f5
3 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/citra_qt/debugger/disassembler.cpp
View File

@ -232,11 +232,8 @@ void DisassemblerWidget::OnDebugModeEntered()
{
ARMword next_instr = Core::g_app_core->GetPC();
// TODO: Make BreakPoints less crappy (i.e. const-correct) so that this doesn't need a const_cast.
if (const_cast<BreakPoints&>(model->GetBreakPoints()).IsAddressBreakPoint(next_instr))
{
if (model->GetBreakPoints().IsAddressBreakPoint(next_instr))
emu_thread.SetCpuRunning(false);
}
model->SetNextInstruction(next_instr);

4
src/common/break_points.cpp
View File

@ -10,14 +10,14 @@
#include <sstream>
#include <algorithm>
bool BreakPoints::IsAddressBreakPoint(u32 iAddress)
bool BreakPoints::IsAddressBreakPoint(u32 iAddress) const
{
auto cond = [&iAddress](const TBreakPoint& bp) { return bp.iAddress == iAddress; };
auto it = std::find_if(m_BreakPoints.begin(), m_BreakPoints.end(), cond);
return it != m_BreakPoints.end();
}
bool BreakPoints::IsTempBreakPoint(u32 iAddress)
bool BreakPoints::IsTempBreakPoint(u32 iAddress) const
{
auto cond = [&iAddress](const TBreakPoint& bp) { return bp.iAddress == iAddress && bp.bTemporary; };
auto it = std::find_if(m_BreakPoints.begin(), m_BreakPoints.end(), cond);

4
src/common/break_points.h
View File

@ -56,8 +56,8 @@ public:
void AddFromStrings(const TBreakPointsStr& bps);
// is address breakpoint
bool IsAddressBreakPoint(u32 iAddress);
bool IsTempBreakPoint(u32 iAddress);
bool IsAddressBreakPoint(u32 iAddress) const;
bool IsTempBreakPoint(u32 iAddress) const;
// Add BreakPoint
void Add(u32 em_address, bool temp=false);