OpenPunk/citra
1
0
Fork 0
mirror of https://github.com/citra-emu/citra.git synced 2024-11-22 21:30:06 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #236 from rohit-n/sign-compare

Browse Source 
Silence a few -Wsign-compare warnings.
This commit is contained in:
bunnei 2014-12-03 10:04:47 -05:00
commit 63b1453dd8
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/video_core/command_processor.cpp
View File

@ -60,7 +60,7 @@ static inline void WritePicaReg(u32 id, u32 value, u32 mask) {
const u8* load_address = base_address + loader_config.data_offset; const u8* load_address = base_address + loader_config.data_offset;
// TODO: What happens if a loader overwrites a previous one's data? // TODO: What happens if a loader overwrites a previous one's data?
for (int component = 0; component < loader_config.component_count; ++component) { for (unsigned component = 0; component < loader_config.component_count; ++component) {
u32 attribute_index = loader_config.GetComponent(component); u32 attribute_index = loader_config.GetComponent(component);
vertex_attribute_sources[attribute_index] = load_address; vertex_attribute_sources[attribute_index] = load_address;
vertex_attribute_strides[attribute_index] = static_cast<u32>(loader_config.byte_count); vertex_attribute_strides[attribute_index] = static_cast<u32>(loader_config.byte_count);

8
src/video_core/debug_utils/debug_utils.cpp
View File

@ -155,7 +155,7 @@ void DumpShader(const u32* binary_data, u32 binary_size, const u32* swizzle_data
// This is put into a try-catch block to make sure we notice unknown configurations. // This is put into a try-catch block to make sure we notice unknown configurations.
std::vector<OutputRegisterInfo> output_info_table; std::vector<OutputRegisterInfo> output_info_table;
for (int i = 0; i < 7; ++i) { for (unsigned i = 0; i < 7; ++i) {
using OutputAttributes = Pica::Regs::VSOutputAttributes; using OutputAttributes = Pica::Regs::VSOutputAttributes;
// TODO: It's still unclear how the attribute components map to the register! // TODO: It's still unclear how the attribute components map to the register!
@ -375,8 +375,8 @@ void DumpTexture(const Pica::Regs::TextureConfig& texture_config, u8* data) {
png_write_info(png_ptr, info_ptr); png_write_info(png_ptr, info_ptr);
buf = new u8[row_stride * texture_config.height]; buf = new u8[row_stride * texture_config.height];
for (int y = 0; y < texture_config.height; ++y) { for (unsigned y = 0; y < texture_config.height; ++y) {
for (int x = 0; x < texture_config.width; ++x) { for (unsigned x = 0; x < texture_config.width; ++x) {
// Cf. rasterizer code for an explanation of this algorithm. // Cf. rasterizer code for an explanation of this algorithm.
int texel_index_within_tile = 0; int texel_index_within_tile = 0;
for (int block_size_index = 0; block_size_index < 3; ++block_size_index) { for (int block_size_index = 0; block_size_index < 3; ++block_size_index) {
@ -402,7 +402,7 @@ void DumpTexture(const Pica::Regs::TextureConfig& texture_config, u8* data) {
} }
// Write image data // Write image data
for (auto y = 0; y < texture_config.height; ++y) for (unsigned y = 0; y < texture_config.height; ++y)
{ {
u8* row_ptr = (u8*)buf + y * row_stride; u8* row_ptr = (u8*)buf + y * row_stride;
u8* ptr = row_ptr; u8* ptr = row_ptr;

2
src/video_core/renderer_opengl/renderer_opengl.cpp
View File

@ -61,7 +61,7 @@ void RendererOpenGL::SwapBuffers() {
for(int i : {0, 1}) { for(int i : {0, 1}) {
const auto& framebuffer = GPU::g_regs.framebuffer_config[i]; const auto& framebuffer = GPU::g_regs.framebuffer_config[i];
if (textures[i].width != framebuffer.width || textures[i].height != framebuffer.height) { if (textures[i].width != (GLsizei)framebuffer.width || textures[i].height != (GLsizei)framebuffer.height) {
// Reallocate texture if the framebuffer size has changed. // Reallocate texture if the framebuffer size has changed.
// This is expected to not happen very often and hence should not be a // This is expected to not happen very often and hence should not be a
// performance problem. // performance problem.