OpenPunk/citra
1
0
Fork 0
mirror of https://github.com/citra-emu/citra.git synced 2024-11-26 20:10:05 +00:00
Code Issues Projects Releases Wiki Activity

armemu: Fix PKHTB to do an arithmetic shift and correctly decode immediate field.

Browse Source
This commit is contained in:
bunnei 2014-12-28 16:18:52 -05:00
parent 082f5b2311
commit 58cb62fe7b
1 changed files with 5 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/core/arm/interpreter/armemu.cpp
View File

@ -3100,7 +3100,6 @@ mainswitch:
break; break;
case 0x68: /* Store Word, No WriteBack, Post Inc, Reg. */ case 0x68: /* Store Word, No WriteBack, Post Inc, Reg. */
//ichfly PKHBT PKHTB todo check this
if ((instr & 0x70) == 0x10) { //pkhbt if ((instr & 0x70) == 0x10) { //pkhbt
u8 idest = BITS(12, 15); u8 idest = BITS(12, 15);
u8 rfis = BITS(16, 19); u8 rfis = BITS(16, 19);
@ -3109,18 +3108,11 @@ mainswitch:
state->Reg[idest] = (state->Reg[rfis] & 0xFFFF) | ((state->Reg[rlast] << ishi) & 0xFFFF0000); state->Reg[idest] = (state->Reg[rfis] & 0xFFFF) | ((state->Reg[rlast] << ishi) & 0xFFFF0000);
break; break;
} else if ((instr & 0x70) == 0x50) { //pkhtb } else if ((instr & 0x70) == 0x50) { //pkhtb
const u8 rd_idx = BITS(12, 15); u8 rd_idx = BITS(12, 15);
const u8 rn_idx = BITS(16, 19); u8 rn_idx = BITS(16, 19);
const u8 rm_idx = BITS(0, 3); u8 rm_idx = BITS(0, 3);
const u8 imm5 = BITS(7, 11); u8 imm5 = BITS(7, 11) ? BITS(7, 11) : 31;
state->Reg[rd_idx] = ((static_cast<s32>(state->Reg[rm_idx]) >> imm5) & 0xFFFF) | ((state->Reg[rn_idx]) & 0xFFFF0000);
ARMword val;
if (imm5 >= 32)
val = (state->Reg[rm_idx] >> 31);
else
val = (state->Reg[rm_idx] >> imm5);
state->Reg[rd_idx] = (val & 0xFFFF) | ((state->Reg[rn_idx]) & 0xFFFF0000);
break; break;
} else if (BIT (4)) { } else if (BIT (4)) {
#ifdef MODE32 #ifdef MODE32