Common: Simplify uppercase/lowercase string functions.

Also changed it to not modify the given string, but rather return a copy of it.

src/common/string_util.cpp

@@ -3,6 +3,7 @@
 // Refer to the license.txt file included.
 
 #include <algorithm>
+#include <cctype>
 #include <cstdlib>
 #include <cstdio>
 
@@ -18,19 +19,15 @@
 #endif
 
 /// Make a string lowercase
-void LowerStr(char* str) {
+std::string ToLowerCaseString(std::string input) {
-    for (int i = 0; str[i]; i++) {
+    std::transform(input.begin(), input.end(), input.begin(), ::tolower);
-        str[i] = tolower(str[ i ]);
+    return input;
-    }
 }
 
 /// Make a string uppercase
-void UpperStr(char* str) {
+std::string ToUpperCaseString(std::string input) {
-    for (int i=0; i < strlen(str); i++) {
+    std::transform(input.begin(), input.end(), input.begin(), ::toupper);
-        if(str[i] >= 'a' && str[i] <= 'z') {
+    return input;
-            str[i] &= 0xDF;
-        }
-    }
 }
 
 // faster than sscanf

src/common/string_util.h

@@ -13,10 +13,10 @@
 #include "common/common.h"
 
 /// Make a string lowercase
-void LowerStr(char* str);
+std::string ToLowerCaseString(std::string input);
 
 /// Make a string uppercase
-void UpperStr(char* str);
+std::string ToUpperCaseString(std::string input);
 
 std::string StringFromFormat(const char* format, ...);
 // Cheap!