Code guidelines fixes

This commit is contained in:
Alexandre LittleWhite Laurent 2016-08-19 14:35:22 +02:00
parent 4e097e05d2
commit 0df188969f
6 changed files with 16 additions and 25 deletions

View File

@ -58,7 +58,7 @@ private:
/// Is the window still open?
bool is_open = true;
/// Is the window has focus
/// Does the window has focus
bool has_focus = true;
/// Internal SDL2 render window

View File

@ -136,22 +136,16 @@ public slots:
signals:
/// Emitted when the window is closed
void Closed();
/// Emitted when the window focus changed
void focusChanged(bool hasFocus);
/// Emitted when the window focus changes
void focusChanged(bool has_focus);
private:
void OnMinimalClientAreaChangeRequest(const std::pair<unsigned,unsigned>& minimal_size) override;
/**
* Capture focus gain to unset pause
* @param event
*/
/// Capture focus gain to unset pause
void focusInEvent(QFocusEvent*) override;
/**
* Capture focus lost to set pause
* @param event
*/
/// Capture focus lost to set pause
void focusOutEvent(QFocusEvent*) override;
GGLWidgetInternal* child;

View File

@ -489,7 +489,7 @@ void GMainWindow::OnStopGame() {
ShutdownGame();
}
void GMainWindow::OnFocusChanged(bool hasFocus) {
void GMainWindow::OnFocusChanged(bool has_focus) {
// The focus change does not impact actual emulator state if:
// - the option is disabled
// - the emulation is not started
@ -499,10 +499,7 @@ void GMainWindow::OnFocusChanged(bool hasFocus) {
emulation_paused)
return;
if (hasFocus)
emu_thread->SetRunning(true);
else // focus lost
emu_thread->SetRunning(false);
emu_thread->SetRunning(has_focus);
}
void GMainWindow::ToggleWindowMode() {

View File

@ -99,7 +99,7 @@ private slots:
void OnPauseGame();
void OnStopGame();
/// Called whenever the render window focus is changed
void OnFocusChanged(bool hasFocus);
void OnFocusChanged(bool has_focus);
/// Called whenever a user selects a game in the game list widget.
void OnGameListLoadFile(QString game_path);
void OnMenuLoadFile();