From 2b9d0f6babffbc81c2a480b83b467f75239fa7c1 Mon Sep 17 00:00:00 2001 From: dongresource Date: Fri, 9 Oct 2020 18:24:16 +0200 Subject: [PATCH] Fix GROUP_JOIN_FAIL being initialized as a GROUP_INVITE_FAIL. This was a vulnerability, since JOIN_FAIL is larger than INVITE_FAIL. --- src/GroupManager.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/GroupManager.cpp b/src/GroupManager.cpp index d3902f0..d7c1ddd 100644 --- a/src/GroupManager.cpp +++ b/src/GroupManager.cpp @@ -95,7 +95,7 @@ void GroupManager::joinGroup(CNSocket* sock, CNPacketData* data) { // fail if the group is full the other player is already in a group if (plr->groupCnt > 1 || plr->iIDGroup != plr->iID || otherPlr->groupCnt >= 4) { - INITSTRUCT(sP_FE2CL_PC_GROUP_INVITE_FAIL, resp); + INITSTRUCT(sP_FE2CL_PC_GROUP_JOIN_FAIL, resp); sock->sendPacket((void*)&resp, P_FE2CL_PC_GROUP_JOIN_FAIL, sizeof(sP_FE2CL_PC_GROUP_JOIN_FAIL)); return; }